fixed broken doc links #22088
Merged
fixed broken doc links #22088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SANTHOSH-MAMIDISETTI
requested review from
tsavina
and removed request for
a team
|
I guess , there is no need for the workflows to run(at least for this case) because it's just a documentation error correction. Thinking we can skip the workflows for now since it's just a quick correction on that front. Saves a bit of hassle and resources. What would you suggest ? @p-wysocki @tsavina |
sgolebiewski-intel
approved these changes
Jan 11, 2024
p-wysocki
approved these changes
Jan 11, 2024
|
Thank you for the contribution! |
|
@p-wysocki just curious , when might this be merged ? , or is there anything to be done , for it to be merged ? |
I mean this PR is still open , hence asking , if there is anything else to be done from my side |
|
@SANTHOSH-MAMIDISETTI I just updated the branch, the CI got stuck for some reason. I'll ask for a merge once the tests pass, it's going to be easier than force merge. :) |
Thank you @p-wysocki :) |
ilya-lavrenov
added a commit
that referenced
this pull request
Jan 19, 2024
* [CI] [GHA] Introduce JS API as a part of the existing workflows (#21898) * add js api to linux * try inside the ov repo * use rel path * use a separate job for js api * correct command formatting * add missing var * use spacing * mv js building * add node installing * add to windows * check pwsh and cmd running npm * add smart CI conditions; disable for win * use node version as env var * extract js job into a separate workflow, add to other *nix * fix input name * Activate js bindings tests for arm64 * upload ov js package * correct formatting * add missing syntax --------- Co-authored-by: Vishniakov Nikolai <[email protected]> * Cmake Python build option flags should be added to the command in step #3 not step #4. I fixed the typo (#21993) * [CI] [GHA] [JS API] Remove explicit default values settings in Linux ARM64 `cmake` (#22019) * rm explicit default values settings * Activate mac arm64 js api check * Specify test run --------- Co-authored-by: Vishniakov Nikolai <[email protected]> * [OV JS] Activate validation for mac x86 (#22035) * Extend validation for mac x86 * Remove extra params * fixed broken doc links (#22088) Co-authored-by: Przemyslaw Wysocki <[email protected]> * [GHA] Update MO deps (#22130) * [GHA] Update MO deps Signed-off-by: Kazantsev, Roman <[email protected]> * Update .github/components.yml --------- Signed-off-by: Kazantsev, Roman <[email protected]> * Avoid DOWNLOAD_EXTRACT_TIMESTAMP warning (#22135) * Avoid DOWNLOAD_EXTRACT_TIMESTAMP warning * Change applying policy condition Co-authored-by: Ilya Lavrenov <[email protected]> --------- Co-authored-by: Ilya Lavrenov <[email protected]> * Fixed API validator search (#22136) * [OV JS] Conditional enabling of JS API (#22139) * Disable js api building for vcpkg * Disable JS API by default * Add disable JS API conditions in features.cmake * Update cmake/features.cmake * Update src/bindings/js/CMakeLists.txt --------- Co-authored-by: Ilya Lavrenov <[email protected]> * Fixed GHSA-h5c8-rqwp-cp95 (#22159) * [PyOV][SAMPLES] Fix bugbear issue B038 (#22183) * Fixed compilation on GHA CI * Decrease number of workers for ONNX Model tests to prevent OOM kills (#22243) * Decrease number of workers for ONNX Model tests to prevent OOM kills * Try to use "-n auto" also --------- Signed-off-by: Kazantsev, Roman <[email protected]> Co-authored-by: Andrei Kashchikhin <[email protected]> Co-authored-by: Vishniakov Nikolai <[email protected]> Co-authored-by: fredrickomondi <[email protected]> Co-authored-by: Santhosh Mamidisetti <[email protected]> Co-authored-by: Przemyslaw Wysocki <[email protected]> Co-authored-by: Roman Kazantsev <[email protected]> Co-authored-by: Jan Iwaszkiewicz <[email protected]> Co-authored-by: Andrey Babushkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
This looked like a relatively minor issue , hence I didn't create an issue ,instead fixed it and made a PR
@p-wysocki