-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port and clean behavior/ shared tests #1
#21860
Merged
vurusovs
merged 5 commits into
openvinotoolkit:master
from
vurusovs:vu/behavior_tests_clean
Jan 4, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
35b258e
Remove `set_preprocess.cpp`
vurusovs c4bed2f
Remove `preprocessing.hpp`
vurusovs 53187bc
Remove `locale.hpp` - ported to `CanCompileModelWithCustomLocale`
vurusovs 0db06ec
Port `version.cpp` and remove legacy
vurusovs 0ab3b5c
Revert shared `version.hpp`
vurusovs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
src/plugins/auto/tests/functional/shared_tests_instances/behavior/ov_plugin/version.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Copyright (C) 2018-2023 Intel Corporation | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
|
|
||
| #include "behavior/ov_plugin/version.hpp" | ||
|
|
||
| namespace ov { | ||
| namespace test { | ||
| namespace behavior { | ||
|
|
||
| INSTANTIATE_TEST_SUITE_P(smoke_Multi_BehaviorTests, | ||
| VersionTests, | ||
| ::testing::Values(ov::test::utils::DEVICE_MULTI), | ||
| VersionTests::getTestCaseName); | ||
|
|
||
| INSTANTIATE_TEST_SUITE_P(smoke_Auto_BehaviorTests, | ||
| VersionTests, | ||
| ::testing::Values(ov::test::utils::DEVICE_AUTO), | ||
| VersionTests::getTestCaseName); | ||
|
|
||
| } // namespace behavior | ||
| } // namespace test | ||
| } // namespace ov |
18 changes: 0 additions & 18 deletions
18
src/plugins/auto/tests/functional/shared_tests_instances/behavior/plugin/version.cpp
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
src/plugins/intel_cpu/tests/functional/shared_tests_instances/behavior/plugin/version.cpp
This file was deleted.
Oops, something went wrong.
14 changes: 0 additions & 14 deletions
14
.../intel_gpu/tests/functional/shared_tests_instances/behavior/executable_network/locale.cpp
This file was deleted.
Oops, something went wrong.
23 changes: 23 additions & 0 deletions
23
src/plugins/intel_gpu/tests/functional/shared_tests_instances/behavior/ov_plugin/version.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Copyright (C) 2018-2023 Intel Corporation | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
|
|
||
| #include "behavior/ov_plugin/version.hpp" | ||
|
|
||
| namespace ov { | ||
| namespace test { | ||
| namespace behavior { | ||
|
|
||
| INSTANTIATE_TEST_SUITE_P(smoke_BehaviorTests, | ||
| VersionTests, | ||
| ::testing::Values(ov::test::utils::DEVICE_GPU), | ||
| VersionTests::getTestCaseName); | ||
|
|
||
| INSTANTIATE_TEST_SUITE_P(smoke_Hetero_BehaviorTests, | ||
| VersionTests, | ||
| ::testing::Values(ov::test::utils::DEVICE_HETERO), | ||
| VersionTests::getTestCaseName); | ||
|
|
||
| } // namespace behavior | ||
| } // namespace test | ||
| } // namespace ov | ||
16 changes: 0 additions & 16 deletions
16
src/plugins/intel_gpu/tests/functional/shared_tests_instances/behavior/plugin/version.cpp
This file was deleted.
Oops, something went wrong.
18 changes: 18 additions & 0 deletions
18
src/plugins/template/tests/functional/shared_tests_instances/behavior/ov_plugin/version.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // Copyright (C) 2018-2023 Intel Corporation | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
|
|
||
| #include "behavior/ov_plugin/version.hpp" | ||
|
|
||
| namespace ov { | ||
| namespace test { | ||
| namespace behavior { | ||
|
|
||
| INSTANTIATE_TEST_SUITE_P(smoke_BehaviorTests, | ||
| VersionTests, | ||
| ::testing::Values(ov::test::utils::DEVICE_TEMPLATE), | ||
| VersionTests::getTestCaseName); | ||
|
|
||
| } // namespace behavior | ||
| } // namespace test | ||
| } // namespace ov |
18 changes: 0 additions & 18 deletions
18
src/plugins/template/tests/functional/shared_tests_instances/behavior/plugin/version.cpp
This file was deleted.
Oops, something went wrong.
33 changes: 0 additions & 33 deletions
33
src/tests/functional/plugin/shared/include/behavior/executable_network/locale.hpp
This file was deleted.
Oops, something went wrong.
143 changes: 0 additions & 143 deletions
143
src/tests/functional/plugin/shared/include/behavior/plugin/preprocessing.hpp
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As my understanding, we should remove meta plugin tests cases from hardware plugin and put them
into conformance tests, am i right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment it isn't clear for me how tests should migrate to conformance scope. So let's merge as is in order to get rid of API1.0 cases, and when only 2.0 cases will be available, it should be easier to migrate
@iefode @sbalandi FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @riverlijunjie @vurusovs meta plugins in the conformance scope are tested with the TEMPLATE plugin now.
All API 1.0 tests have been removed from the conformance scope, but there are some tests that have not yet been moved to the 2.0 scope and version tests were among them, so I will add these tests to conformance, thank you !