Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port and clean behavior/ shared tests #1 #21860

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Port and clean behavior/ shared tests #1 #21860

merged 5 commits into from
Jan 4, 2024

Conversation

vurusovs
Copy link
Contributor

No description provided.

@vurusovs vurusovs added this to the 2024.0 milestone Dec 25, 2023
@vurusovs vurusovs requested review from a team as code owners December 25, 2023 12:06
@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin category: CPU OpenVINO CPU plugin category: TEMPLATE OpenVINO Template plugin category: AUTO OpenVINO AUTO device selection plugin labels Dec 25, 2023
@vurusovs vurusovs force-pushed the vu/behavior_tests_clean branch from 95e6f90 to b043ef1 Compare December 27, 2023 11:47
@vurusovs vurusovs force-pushed the vu/behavior_tests_clean branch from b043ef1 to 0ab3b5c Compare January 4, 2024 09:28
@vurusovs vurusovs changed the title [WIP] Port and clean behavior/ shared tests Port and clean behavior/ shared tests #1 Jan 4, 2024
riverlijunjie
riverlijunjie reviewed Jan 4, 2024
View reviewed changes
src/plugins/intel_gpu/tests/functional/shared_tests_instances/behavior/ov_plugin/version.cpp

INSTANTIATE_TEST_SUITE_P(smoke_Hetero_BehaviorTests,
VersionTests,
::testing::Values(ov::test::utils::DEVICE_HETERO),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As my understanding, we should remove meta plugin tests cases from hardware plugin and put them
into conformance tests, am i right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment it isn't clear for me how tests should migrate to conformance scope. So let's merge as is in order to get rid of API1.0 cases, and when only 2.0 cases will be available, it should be easier to migrate

@iefode @sbalandi FYI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @riverlijunjie @vurusovs meta plugins in the conformance scope are tested with the TEMPLATE plugin now.
All API 1.0 tests have been removed from the conformance scope, but there are some tests that have not yet been moved to the 2.0 scope and version tests were among them, so I will add these tests to conformance, thank you !

@vurusovs vurusovs merged commit 05f65ad into openvinotoolkit:master Jan 4, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbalandi sbalandi sbalandi left review comments

@riverlijunjie riverlijunjie riverlijunjie left review comments

@praasz praasz praasz approved these changes

Assignees

@riverlijunjie riverlijunjie

@zhaixuejun1993 zhaixuejun1993

Labels
category: AUTO OpenVINO AUTO device selection plugin category: CPU OpenVINO CPU plugin category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Milestone
2024.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vurusovs @riverlijunjie @sbalandi @praasz @zhaixuejun1993