Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref][Core][Opset13] BitwiseAnd, BitwiseOr and BitwiseXor core shell and reference #20058

Merged

Conversation

mmikolajcz
Copy link
Contributor

Details:

  • BitwiseAnd-13 core shell and reference implementation
  • BitwiseOr-13 core shell and reference implementation
  • BitwiseXor-13 core shell and reference implementation
  • Support for 1bit and 4bit integers will be considered in separate PR

PR with spec: #19798

Related to BitwiseNot: #19956

Tickets:

  • BitwiseAnd: 118964, 118963, 118965
  • BitwiseOr: 118972, 118971, 118973
  • BitwiseXor: 118948, 118947, 118949

@mmikolajcz mmikolajcz added the category: Opset OpenVINO Opset label Sep 26, 2023
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: TEMPLATE OpenVINO Template plugin category: CPP API OpenVINO CPP API bindings labels Sep 26, 2023
@mmikolajcz mmikolajcz marked this pull request as ready for review September 26, 2023 16:59
@mmikolajcz mmikolajcz requested review from a team as code owners September 26, 2023 16:59
src/core/src/op/bitwise_and.cpp Outdated Show resolved Hide resolved
src/core/src/op/bitwise_and.cpp Outdated Show resolved Hide resolved
src/core/src/op/bitwise_and.cpp Outdated Show resolved Hide resolved
src/core/src/op/bitwise_or.cpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/bitwise_ops.hpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/bitwise_ops.hpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/bitwise_ops.hpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/bitwise_ops.hpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/bitwise_ops.hpp Outdated Show resolved Hide resolved
mmikolajcz and others added 2 commits October 3, 2023 10:54
…ance_runner/src/op_impl_check/single_op_graph.cpp

Co-authored-by: Tomasz Jankowski <[email protected]>
@mmikolajcz mmikolajcz requested a review from praasz October 3, 2023 10:59
@mmikolajcz mmikolajcz requested a review from t-jankowski October 3, 2023 10:59
@mmikolajcz mmikolajcz requested a review from praasz October 3, 2023 14:06
@mlukasze mlukasze enabled auto-merge (squash) October 4, 2023 05:50
@mlukasze mlukasze merged commit 7926302 into openvinotoolkit:master Oct 4, 2023
35 checks passed
alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
…and reference (openvinotoolkit#20058)

* Add Bitwise binary core and refs

* Add draft for tests

* Formatting, build issues and tests

* Fix tests

* Add reference tests

* Apply requested changes

* Add requested changes

* Rename

* uncomment test

* Update src/tests/functional/plugin/conformance/test_runner/op_conformance_runner/src/op_impl_check/single_op_graph.cpp

Co-authored-by: Tomasz Jankowski <[email protected]>

* change reference

---------

Co-authored-by: Tomasz Jankowski <[email protected]>
allnes pushed a commit to allnes/openvino that referenced this pull request Nov 23, 2023
…and reference (openvinotoolkit#20058)

* Add Bitwise binary core and refs

* Add draft for tests

* Formatting, build issues and tests

* Fix tests

* Add reference tests

* Apply requested changes

* Add requested changes

* Rename

* uncomment test

* Update src/tests/functional/plugin/conformance/test_runner/op_conformance_runner/src/op_impl_check/single_op_graph.cpp

Co-authored-by: Tomasz Jankowski <[email protected]>

* change reference

---------

Co-authored-by: Tomasz Jankowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: IE Tests OpenVINO Test: plugins and common category: Opset OpenVINO Opset category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants