Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ref][Core][Opset13] Add BitwiseNot operation #19956

Merged
merged 17 commits into from
Sep 27, 2023
Merged

[Ref][Core][Opset13] Add BitwiseNot operation #19956

merged 17 commits into from
Sep 27, 2023

Conversation

mmikolajcz
Copy link
Contributor

Details:

  • Add Core, Reference implementation and template tests for BitwiseNot operator
  • Support for 1bit and 4bit integers will be considered in separate PR
  • Code contains some commented out placeholders for other bitwise operators and will be enabled in separate PR

Tickets:

  • 118956
  • 118955

@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: TEMPLATE OpenVINO Template plugin category: CPP API OpenVINO CPP API bindings labels Sep 19, 2023
@mmikolajcz mmikolajcz added the category: Opset OpenVINO Opset label Sep 19, 2023
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Sep 20, 2023
@mmikolajcz mmikolajcz marked this pull request as ready for review September 20, 2023 13:01
@mmikolajcz mmikolajcz requested review from a team as code owners September 20, 2023 13:01
praasz
praasz reviewed Sep 20, 2023
View reviewed changes
src/core/reference/include/openvino/reference/not.hpp Outdated Show resolved Hide resolved
src/plugins/template/backend/ops/bitwise_not.cpp Outdated Show resolved Hide resolved
src/plugins/template/tests/functional/op_reference/bitwise.hpp Outdated Show resolved Hide resolved
src/plugins/template/tests/functional/op_reference/bitwise.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/op/bitwise_not.hpp Outdated Show resolved Hide resolved
src/plugins/template/backend/ops/bitwise_not.cpp Outdated Show resolved Hide resolved
src/core/src/op/bitwise_not.cpp Show resolved Hide resolved
src/core/src/op/bitwise_not.cpp Outdated Show resolved Hide resolved
src/core/src/op/bitwise_not.cpp Outdated Show resolved Hide resolved
@mmikolajcz mmikolajcz requested a review from a team as a code owner September 22, 2023 09:36
@github-actions github-actions bot added the category: extensions OpenVINO Extensibility Mechanism for custom operations label Sep 22, 2023
@mmikolajcz mmikolajcz requested a review from praasz September 22, 2023 10:15
@mlukasze mlukasze enabled auto-merge (squash) September 25, 2023 05:32
@mmikolajcz mmikolajcz disabled auto-merge September 25, 2023 07:41
praasz
praasz approved these changes Sep 25, 2023
View reviewed changes
src/core/tests/type_prop/bitwise_not.cpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/bitwise_not.cpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/bitwise_not.cpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/bitwise_not.cpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/bitwise_not.cpp Show resolved Hide resolved
@github-actions github-actions bot removed the category: extensions OpenVINO Extensibility Mechanism for custom operations label Sep 25, 2023
@mmikolajcz mmikolajcz mentioned this pull request Sep 26, 2023
Merged
@mlukasze mlukasze enabled auto-merge (squash) September 27, 2023 05:26
@mlukasze mlukasze merged commit f5fe664 into openvinotoolkit:master Sep 27, 2023
alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
@mmikolajcz @alvoron
[Ref][Core][Opset13] Add BitwiseNot operation (openvinotoolkit#19956)
9677eae 
* [Ref][Core][Opset13] Add bitwise_not operation

* Fix CI issues + add missing test

* improve test

* formatting

* Requested changes

* Remove unused include

* Add requested changes

* Try to fix test problems

* Fix CI

* Fix type validation

* Add checks in template eval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz approved these changes

@mitruska mitruska mitruska approved these changes

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: IE Tests OpenVINO Test: plugins and common category: Opset OpenVINO Opset category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmikolajcz @mitruska @praasz @mlukasze