Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LPT] NNCF GroupConvolution 5D on weights support #16336

Merged
merged 2 commits into from
Mar 23, 2023
Merged

[LPT] NNCF GroupConvolution 5D on weights support #16336

merged 2 commits into from
Mar 23, 2023

Conversation

eshoguli
Copy link
Contributor

@eshoguli eshoguli commented Mar 16, 2023 •
edited
Loading

Details:

  • GroupConvolution with 5D on weights support

Tickets:

  • 102846

@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: LP transformations OpenVINO Low Precision transformations labels Mar 16, 2023
@eshoguli eshoguli force-pushed the es/lpt/openvino_nncf_5d_support branch from ea6e63f to cf154df Compare March 16, 2023 11:23
@eshoguli eshoguli changed the title [LPT] NNCF GroupConvolution 5D on weights support [DRAFT] [LPT] NNCF GroupConvolution 5D on weights support Mar 16, 2023
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Mar 20, 2023
@eshoguli eshoguli force-pushed the es/lpt/openvino_nncf_5d_support branch from 9ba8ac6 to 08573bf Compare March 20, 2023 14:04
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Mar 20, 2023
@eshoguli eshoguli force-pushed the es/lpt/openvino_nncf_5d_support branch 3 times, most recently from 55a1d21 to 3f7660d Compare March 20, 2023 14:34
@eshoguli eshoguli marked this pull request as ready for review March 20, 2023 15:50
@eshoguli eshoguli requested review from a team as code owners March 20, 2023 15:50
@eshoguli eshoguli changed the title [DRAFT] [LPT] NNCF GroupConvolution 5D on weights support [LPT] NNCF GroupConvolution 5D on weights support Mar 20, 2023
@eshoguli eshoguli force-pushed the es/lpt/openvino_nncf_5d_support branch from 3f7660d to 014a79c Compare March 20, 2023 17:05
@eshoguli eshoguli force-pushed the es/lpt/openvino_nncf_5d_support branch 4 times, most recently from 964118e to 401b90d Compare March 20, 2023 21:32
v-Golubev
v-Golubev approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@v-Golubev v-Golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, only minor comments from my side. But please take a look on failed GPU tests

src/common/low_precision_transformations/src/weightable_layer_transformation.cpp Show resolved Hide resolved
src/common/low_precision_transformations/src/convolution.cpp Show resolved Hide resolved
@eshoguli eshoguli force-pushed the es/lpt/openvino_nncf_5d_support branch from 401b90d to 430808e Compare March 21, 2023 13:30
@eshoguli eshoguli force-pushed the es/lpt/openvino_nncf_5d_support branch 2 times, most recently from d7d1d19 to 0112013 Compare March 22, 2023 01:02
@eshoguli eshoguli force-pushed the es/lpt/openvino_nncf_5d_support branch from 0112013 to 4a5fc0d Compare March 22, 2023 10:06
@eshoguli eshoguli merged commit fb24e91 into openvinotoolkit:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-Golubev v-Golubev v-Golubev approved these changes

Assignees

@v-Golubev v-Golubev

@eshoguli eshoguli

Labels
category: CPU OpenVINO CPU plugin category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: LP transformations OpenVINO Low Precision transformations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshoguli @v-Golubev