PullReshapeThroughDequantization rollback

openvinotoolkit · Mar 22, 2023 · 0112013 · 0112013
1 parent 6a066c6
commit 0112013
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 10 deletions.
diff --git a/src/common/low_precision_transformations/src/pull_reshape_through_dequantization.cpp b/src/common/low_precision_transformations/src/pull_reshape_through_dequantization.cpp
@@ -114,6 +114,11 @@ ngraph::pass::low_precision::PullReshapeThroughDequantization::PullReshapeThroug
         const auto& opsMap = m.get_pattern_value_map();
         auto reshape = opsMap.at(reshapeWrapper).get_node_shared_ptr();
 
+        auto child = reshape->get_output_target_inputs(0).begin()->get_node();
+        if (ov::is_type<opset1::GroupConvolution>(child)) {
+            return false;
+        }
+
         while (reshape != nullptr) {
             const auto parent = reshape->get_input_node_shared_ptr(0);
             if (ov::is_type<opset1::Multiply>(parent) || ov::is_type<opset1::Subtract>(parent)) {

diff --git a/...ow_precision_transformations/tests/pull_reshape_through_dequantization_transformation.cpp b/...ow_precision_transformations/tests/pull_reshape_through_dequantization_transformation.cpp
@@ -141,8 +141,8 @@ const std::vector<ngraph::Shape> inputShapes = {
 };
 
 const std::vector<std::pair<ngraph::Shape, ngraph::Shape>> dequantizationOnWeightElementwiseConstantShapes = {
-    {ngraph::Shape({1, 960}), ngraph::Shape({960, 1, 1, 1, 1})},
-    {ngraph::Shape({9, 960}), ngraph::Shape({960, 1, 1, 3, 3})}
+    {ngraph::Shape({1, 960}), ngraph::Shape({960, 1, 1, 1})},
+    {ngraph::Shape({9, 960}), ngraph::Shape({960, 1, 3, 3})}
 };
 
 const std::vector<ngraph::Shape> multiplyShapes = {ngraph::Shape({1, 1, 960, 1})};
@@ -230,7 +230,7 @@ const std::vector<PullReshapeThroughDequantizationTestValues> testValues = {
                 { {127.f}, element::f32, {}, false, 1ul, element::u8, true },
                 { {0.02f}, element::f32, {}, false }
             },
-            { std::vector<float>{ 2.f }, ngraph::element::i8, {960, 1, 1, 3, 3}},
+            { std::vector<float>{ 2.f }, ngraph::element::i8, {960, 1, 3, 3}},
             {
                 { ngraph::element::f32, false },
                 { {127.f}, element::f32, {/* from parameter */}, false },
@@ -239,7 +239,7 @@ const std::vector<PullReshapeThroughDequantizationTestValues> testValues = {
             {},
             {},
             {},
-            {},
+            {{960, 1, 1, 3, 3}},
             ngraph::element::f32,
             {}
         }
@@ -327,7 +327,7 @@ const std::vector<PullReshapeThroughDequantizationTestValues> testValues = {
                 { {127.f}, element::f32, {}, false, 1ul, element::u8, true },
                 { {0.02f}, element::f32, {}, false }
             },
-            { std::vector<float>{ 2.f }, ngraph::element::i8, {960, 1, 1, 3, 3}},
+            { std::vector<float>{ 2.f }, ngraph::element::i8, {960, 1, 3, 3}},
             {
                 { ngraph::element::f32, false },
                 { {127.f}, element::f32, {/* from parameter */}, false, 1ul, element::i8, true },
@@ -336,7 +336,7 @@ const std::vector<PullReshapeThroughDequantizationTestValues> testValues = {
             {},
             {},
             {},
-            {},
+            {{960, 1, 1, 3, 3}},
             ngraph::element::f32,
             {}
         }

diff --git a/..._precision_transformations/tests/pull_transpose_through_dequantization_transformation.cpp b/..._precision_transformations/tests/pull_transpose_through_dequantization_transformation.cpp
@@ -134,8 +134,8 @@ const std::vector<ngraph::Shape> inputShapes = {
 };
 
 const std::vector<std::pair<ngraph::Shape, ngraph::Shape>> dequantizationOnWeightElementwiseConstantShapes = {
-    {ngraph::Shape({}), ngraph::Shape({1, 1, 1, 1, 1})},
-    {ngraph::Shape({1}), ngraph::Shape({1, 1, 1, 1, 1})}};
+    {ngraph::Shape({}), ngraph::Shape({1, 1, 1, 1})},
+    {ngraph::Shape({1}), ngraph::Shape({1, 1, 1, 1})}};
 
 const std::vector<PullTransposeThroughDequantizationTestValues> testValues = {
     // Actual:
@@ -214,7 +214,7 @@ const std::vector<PullTransposeThroughDequantizationTestValues> testValues = {
                 {{127.f}, element::f32, {}, false, 1ul, element::u8, true},
                 {{0.02f}, element::f32, {}, false}
             },
-            {std::vector<float>{2.f}, ngraph::element::i8, {960, 1, 1, 3, 3}},
+            {std::vector<float>{2.f}, ngraph::element::i8, {960, 1, 3, 3}},
             {
                 {ngraph::element::f32, false},
                 {{127.f}, element::f32, {/* from parameter */}, false},
@@ -223,7 +223,7 @@ const std::vector<PullTransposeThroughDequantizationTestValues> testValues = {
             {},
             {},
             {},
-            {},
+            {{960, 1, 1, 3, 3}},
             ngraph::element::f32,
             {}
         }