Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snippets][CPU] Added FP32 MHA tokenization support #14327

Merged
merged 20 commits into from
Jan 18, 2023
Merged

[Snippets][CPU] Added FP32 MHA tokenization support #14327

merged 20 commits into from
Jan 18, 2023

Conversation

a-sidorova
Copy link
Contributor

@a-sidorova a-sidorova commented Nov 30, 2022 •
edited
Loading

Details:

  • Added FP32 MHA-pattern support to Snippets

Tickets:

  • 92360

Todo:

  • register new ops as CPU extension like in the serialization PR#14064 (this branch rebase needed)
  • Move changes in the common test infrastructure (1 and 2) to a separate PR, or drop 1 and move 2 to the snippets utils
  • Reset src/tests/functional/shared_test_classes/include/shared_test_classes/base/ov_subgraph.hpp and
    src/tests/functional/shared_test_classes/src/base/utils/generate_inputs.cpp to master after 14343 is merged.
  • Follow-up: remove extra parameters from emit_brgemm_kernel_call in the separate PR

Blocked by:

  • small fix on test infrastructure 14343. UPD: Unblocked

@IvanNovoselov
[Snippets][CPU] Explicit loop (#55)
0075a5f 
* [Snippets] Dynamic loop snapshot

* [Snippets] Explicit Loop implementation
@dmitry-gorokhov dmitry-gorokhov added the category: CPU OpenVINO CPU plugin label Nov 30, 2022
@a-sidorova a-sidorova added category: CPU OpenVINO CPU plugin and removed category: CPU OpenVINO CPU plugin labels Nov 30, 2022
This was referenced Nov 30, 2022
Closed
Closed
Merged
This was referenced Dec 23, 2022
Closed
Closed
Closed
Closed
@a-sidorova a-sidorova added this to the 2023.0 milestone Dec 29, 2022
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference labels Jan 9, 2023
@a-sidorova a-sidorova changed the title [Snippets][CPU] Added MHA tokenization support [Snippets][CPU] Added FP32 MHA tokenization support Jan 9, 2023
@a-sidorova a-sidorova force-pushed the feature/snippets/mha branch 2 times, most recently from ee4aa7a to 07c97a7 Compare January 10, 2023 06:38
@a-sidorova a-sidorova force-pushed the feature/snippets/mha branch from 07c97a7 to 457738b Compare January 10, 2023 08:50
@a-sidorova a-sidorova marked this pull request as ready for review January 10, 2023 11:10
@a-sidorova a-sidorova requested review from a team as code owners January 10, 2023 11:10
@a-sidorova a-sidorova force-pushed the feature/snippets/mha branch from 2166a14 to 1722e43 Compare January 11, 2023 08:47
@a-sidorova a-sidorova requested a review from a team as a code owner January 11, 2023 11:40
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Jan 11, 2023
@a-sidorova a-sidorova force-pushed the feature/snippets/mha branch from dc2f206 to bc47131 Compare January 11, 2023 11:55
IvanNovoselov
IvanNovoselov approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@IvanNovoselov IvanNovoselov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the last changes. LGTM

@a-sidorova a-sidorova mentioned this pull request Jan 12, 2023
Merged
2 tasks
@dmitry-gorokhov dmitry-gorokhov merged commit 6525dd4 into openvinotoolkit:master Jan 18, 2023
@IvanNovoselov IvanNovoselov mentioned this pull request Jan 18, 2023
Merged
jane-intel pushed a commit to jane-intel/openvino that referenced this pull request Jan 19, 2023
@a-sidorova
[Snippets][CPU] Added FP32 MHA tokenization support (openvinotoolkit#…
bae4edc 
…14327)
@IvanNovoselov IvanNovoselov mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanNovoselov IvanNovoselov IvanNovoselov approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: ONNX FE OpenVINO ONNX FrontEnd
Projects
None yet
Milestone
2023.0
Development

Successfully merging this pull request may close these issues.
3 participants
@a-sidorova @dmitry-gorokhov @IvanNovoselov