Sns transpose support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
IvanNovoselov
force-pushed
the
sns_transpose_support
branch
2 times, most recently
from
a153865 to
95739fc
Compare
communication approach
IvanNovoselov
force-pushed
the
sns_transpose_support
branch
from
95739fc to
83c027d
Compare
src/inference/dev_api/cpp_interfaces/interface/ie_internal_plugin_config.hpp
Show resolved
Hide resolved
src/plugins/intel_cpu/tests/functional/shared_tests_instances/snippets/add.cpp
Show resolved
Hide resolved
src/tests/ngraph_helpers/snippets_ngraph_functions/src/subgraph_permute.cpp
Show resolved
Hide resolved
dmitry-gorokhov
approved these changes
Dec 1, 2022
v-Golubev
reviewed
Dec 1, 2022
Comment on lines
+31
to
+34
| const auto transpose = ov::as_type_ptr<ngraph::opset1::Transpose>( | ||
| pattern_to_output.at(match_transpose).get_node_shared_ptr()); | ||
|
|
||
| const auto order = ov::as_type_ptr<ov::op::v0::Constant>(pattern_to_output.at(match_order).get_node_shared_ptr()); |
There was a problem hiding this comment.
To avoid some potential warnings from static analyzers I would recommend to check transpose and order on nullptr
There was a problem hiding this comment.
It's an interesting question. Do we have a common practice on this point?
Because I intentionally skipped the checks to avoid extra penalty in runtime? since the matcher guarantees that they are not nullptr. Let's discuss this on the sync.
src/inference/dev_api/cpp_interfaces/interface/ie_internal_plugin_config.hpp
Show resolved
Hide resolved
src/tests/ngraph_helpers/snippets_ngraph_functions/include/subgraph_permute.hpp
Show resolved
Hide resolved
src/plugins/intel_cpu/tests/functional/shared_tests_instances/snippets/add.cpp
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: