Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[BENCHMARK_APP] Show input command in output" #13956

Closed

Conversation

nkogteva
Copy link
Contributor

Reverts #13402

Windows looks like:
image

@Wovchena
Copy link
Contributor

I already reported that to @PiotrKrzem. As I understand, e92c9f6#diff-e7a536b4318b2270a4ee67f723b8ff57e9a5aed0928c11fa46e5a0b02db6300fR46 fixes that

@nkogteva
Copy link
Contributor Author

I already reported that to @PiotrKrzem. As I understand, e92c9f6#diff-e7a536b4318b2270a4ee67f723b8ff57e9a5aed0928c11fa46e5a0b02db6300fR46 fixes that

I think we don't need this printing from tool at all.

@PiotrKrzem
Copy link
Contributor

PiotrKrzem commented Nov 14, 2022

I already reported that to @PiotrKrzem. As I understand, e92c9f6#diff-e7a536b4318b2270a4ee67f723b8ff57e9a5aed0928c11fa46e5a0b02db6300fR46 fixes that

Yes, this should work just fine now! Compiled on Windows & it does not appear to print empty spaces anymore
image

I already reported that to @PiotrKrzem. As I understand, e92c9f6#diff-e7a536b4318b2270a4ee67f723b8ff57e9a5aed0928c11fa46e5a0b02db6300fR46 fixes that

I think we don't need this printing from tool at all.

Personally, I found the realpath of the executable to be quite useful, other arguments are most often printed in the Step 8 of the application anyways. I'll add @helena-intel to the reviewers so she could also add her insights to this conversation

Copy link
Contributor

@Wovchena Wovchena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving following @p-durandin's mail

@nkogteva
Copy link
Contributor Author

Rebased PR #14027

@nkogteva nkogteva closed this Nov 16, 2022
@vladimir-paramuzov vladimir-paramuzov deleted the revert-13402-feature/benchmark_command_in_output branch November 16, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants