[BENCHMARK_APP] Show input command in output #13402
Conversation
PiotrKrzem
changed the title
PiotrKrzem
requested review from
helena-intel,
eaidova,
nkogteva and
t-jankowski
samples/cpp/benchmark_app/main.cpp
Outdated
| @@ -161,12 +190,16 @@ int main(int argc, char* argv[]) { | |||
|
|
|||
| // ----------------- 1. Parsing and validating input arguments | |||
| // ------------------------------------------------- | |||
| auto args_string = get_console_command(argc, argv); | |||
There was a problem hiding this comment.
What is a reason for doing it inside tool?
There was a problem hiding this comment.
It is easier to verify which benchmark_app is being used, C++ or Python, and from which directory. It can happen for example when the PYTHONPATH/PATH env variable is modified, or after the output alignment PR is merged, when both benchmarks' output is indistinguishable.
There was a problem hiding this comment.
It is easier to verify which benchmark_app is being used, C++ or Python, and from which directory. It can happen for example when the PYTHONPATH/PATH env variable is modified, or after the output alignment PR is merged, when both benchmarks' output is indistinguishable.
Validation related stuff should not be included into the tool. Why this PR was merged? cc @p-durandin
There was a problem hiding this comment.
As pointed out by @helena-intel in the ticket, the idea of this change is to make the usage of the tool and sharing output logs easier for the customers and our coworkers alike, I think this is a valid addition to the tool
There was a problem hiding this comment.
@PiotrKrzem I still don't understand why it is problem to share logs with initial command line. If user have ran tool, he knows what he typed in command line.
There was a problem hiding this comment.
Moreover for some automation scenarios we increase final log size.
…#13402)" (openvinotoolkit#14027) This reverts commit f893a58.
Details:
Tickets: