Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue]: Support aten::masked_select for pytorch models #23325

Closed
mvafin opened this issue Mar 7, 2024 · 9 comments
Closed

[Good First Issue]: Support aten::masked_select for pytorch models #23325

mvafin opened this issue Mar 7, 2024 · 9 comments
Assignees
@hub-bla
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Milestone
2024.4

Comments

@mvafin
Copy link
Contributor

mvafin commented Mar 7, 2024

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD
@mvafin mvafin added good first issue Good for newcomers category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Mar 7, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Mar 7, 2024
@YutingGao7
Copy link

.take

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@rkazants rkazants moved this from Contributors Needed to Assigned in Good first issues Mar 9, 2024
@YutingGao7 YutingGao7 mentioned this issue Mar 10, 2024
Closed
@rkazants rkazants linked a pull request Mar 10, 2024 that will close this issue
[PT FE] [23325] Add aten::masked_select support for pytorch models. #23354
Closed
@mlukasze mlukasze moved this from Assigned to In Review in Good first issues Mar 11, 2024
@mlukasze mlukasze moved this from In Review to Contributors Needed in Good first issues Apr 15, 2024
@psmaxwell
Copy link

#WLB# + .take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Apr 15, 2024
@p-wysocki
Copy link
Contributor

Hello @psmaxwell, are you still working on that issue? Do you need any help?

@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Jul 25, 2024
@hub-bla
Copy link
Contributor

hub-bla commented Aug 21, 2024

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@hub-bla hub-bla mentioned this issue Aug 21, 2024
Merged
@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Aug 23, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 26, 2024
@hub-bla
[PT FE] Support aten::masked_select for pytorch models (#26162)
2660f85 
### Details:
 - support `aten::masked_select` operator

### Tickets:
 - [None](#23325)
@hub-bla
Copy link
Contributor

hub-bla commented Aug 27, 2024 •
edited
Loading

@mlukasze @mvafin This issue can be closed now because of PR #26162.

@mlukasze
Copy link
Contributor

@mvafin please verify and make actions accordingly

@mvafin mvafin closed this as completed Sep 18, 2024
@github-project-automation github-project-automation bot moved this from Assigned to Closed in Good first issues Sep 18, 2024
@mlukasze mlukasze modified the milestones: 2024.5, 2024.4 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hub-bla hub-bla

Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Good first issues
Archived in project
Milestone
2024.4
Development

Successfully merging a pull request may close this issue.

[PT FE] [23325] Add aten::masked_select support for pytorch models. YutingGao7/openvino
6 participants
@mvafin @psmaxwell @mlukasze @p-wysocki @hub-bla @YutingGao7