Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct assert for jit_avx512_core_x8s8s32x_conv_kernel #54

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

EgorDuplensky
Copy link
Collaborator

@EgorDuplensky EgorDuplensky commented May 31, 2021

Otherwise Debug builds fails in the assert() for half of the INT8 nets

@EgorDuplensky
Copy link
Collaborator Author

Assert is located on line 805

@dmitry-gorokhov
Copy link
Collaborator

@EgorDuplensky please create corresponding PR in OV repo

@EgorDuplensky
Copy link
Collaborator Author

@EgorDuplensky please create corresponding PR in OV repo

Already created.
openvinotoolkit/openvino#5936

@EgorDuplensky EgorDuplensky force-pushed the fix_false_positive_assert branch from fea1091 to 0dc81d1 Compare June 4, 2021 18:19
@EgorDuplensky
Copy link
Collaborator Author

Rebased

@dmitry-gorokhov
Copy link
Collaborator

@EgorDuplensky please squash the commits

@EgorDuplensky EgorDuplensky force-pushed the fix_false_positive_assert branch from 0dc81d1 to 9af7669 Compare June 7, 2021 12:38
@EgorDuplensky EgorDuplensky changed the title Correct calculation of maximum accumulation registers Correct assert for jit_avx512_core_x8s8s32x_conv_kernel Jun 7, 2021
@EgorDuplensky
Copy link
Collaborator Author

Done. Commit subject has also been updated with respect to the fix.

@EgorDuplensky EgorDuplensky force-pushed the fix_false_positive_assert branch from 9af7669 to 08072ca Compare June 22, 2021 15:05
@dmitry-gorokhov dmitry-gorokhov merged commit 08072ca into v1.6_for_ie_master Jun 23, 2021
@ilya-lavrenov ilya-lavrenov deleted the fix_false_positive_assert branch April 20, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants