Skip to content

Commit

Permalink
Correct calculation of maximum accumulation registers
Browse files Browse the repository at this point in the history
for jit_avx512_core_x8s8s32x_conv_kernel
  • Loading branch information
EgorDuplensky committed May 31, 2021
1 parent 2f19a90 commit fea1091
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/cpu/x64/jit_avx512_core_x8s8s32x_conv_kernel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1289,7 +1289,6 @@ status_t jit_avx512_core_x8s8s32x_fwd_kernel::init_conf(jit_conv_conf_t &jcp,
const int eltwise_ind = p.find(primitive_kind::eltwise);
jcp.with_eltwise = eltwise_ind != -1;
if (jcp.with_eltwise) jcp.eltwise = p.entry_[eltwise_ind].eltwise;
bool with_quantization = attr.post_ops_.find(primitive_kind::quantization) != -1;

jcp.ver = mayiuse(avx512_core_vnni) ? ver_vnni : ver_avx512_core;
jcp.is_fast_depthwise = true && jcp.is_depthwise && jcp.ver == ver_vnni
Expand All @@ -1301,8 +1300,7 @@ status_t jit_avx512_core_x8s8s32x_fwd_kernel::init_conf(jit_conv_conf_t &jcp,
if (jcp.is_depthwise) {
jcp.max_regs_ur = 31 - jcp.is_fast_depthwise - !jcp.is_resrc_depthwise
- (jcp.signed_input || jcp.with_input_zp) - (jcp.ver != ver_vnni)
- (jcp.signed_input || jcp.with_input_zp || jcp.need_saturation) // both alias
- with_quantization;
- (jcp.signed_input || jcp.with_input_zp || jcp.need_saturation); // both alias
} else {
jcp.max_regs_ur = jcp.ver == ver_vnni ? 31 : 28;
}
Expand Down

0 comments on commit fea1091

Please sign in to comment.