Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve examples #3091

Merged
merged 17 commits into from
Dec 4, 2024
Merged

Improve examples #3091

merged 17 commits into from
Dec 4, 2024

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Nov 15, 2024 •
edited
Loading

Changes

  • Add pattern based on file extension to gitignore for examples
  • Use pathlib style instead os.path
  • Fix issue with creating ../nncf/~/.cache/datasets directory
  • Replace tqdm to nncf.common.logging.track_progress
  • Remove unused function arguments and if conditions
  • Clean logs, disable progress bar, remove log of validataion
  • Pass list of command arguments to subprocess instead of string
  • Remove nncf dependencies from tests/cross_fw/examples
  • Add --reuse-venv to use venv from example directory
  • Add progress bar to collect_values_for_each_item_using_prepared_model

Tests

https://github.com/openvinotoolkit/nncf/actions/runs/11900403097
nightly/job/test_examples/618
nightly/job/windows/job/test-examples/278/

@github-actions github-actions bot added NNCF TF Pull requests that updates NNCF TensorFlow NNCF PT Pull requests that updates NNCF PyTorch NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX labels Nov 15, 2024
@AlexanderDokuchaev AlexanderDokuchaev changed the title examples Improve examples Nov 18, 2024
@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as ready for review November 18, 2024 20:53
@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner November 18, 2024 20:53
@MaximProshin
Copy link
Collaborator

@AlexanderDokuchaev , @alexsu52 , please run SDL checks before the merge (as you changed some imports and the way how 'path' is used). Also make sure it works on Windows.

@github-actions github-actions bot added the NNCF PTQ Pull requests that updates NNCF PTQ label Nov 19, 2024
@AlexanderDokuchaev
Copy link
Collaborator Author

@MaximProshin
/sdl/job/nightly_trigger/346 - pass, exclude checkmarkx: warning about .github/..
nightly/job/windows/job/test-examples/278/

KodiaqQ
KodiaqQ reviewed Nov 20, 2024
View reviewed changes
.github/workflows/examples.yml Show resolved Hide resolved
.gitignore Show resolved Hide resolved
examples/post_training_quantization/onnx/mobilenet_v2/main.py Show resolved Hide resolved
examples/post_training_quantization/onnx/yolov8_quantize_with_accuracy_control/main.py Show resolved Hide resolved
...les/post_training_quantization/openvino/anomaly_stfpm_quantize_with_accuracy_control/main.py Show resolved Hide resolved
examples/post_training_quantization/openvino/yolov8_quantize_with_accuracy_control/main.py Show resolved Hide resolved
examples/post_training_quantization/tensorflow/mobilenet_v2/main.py Outdated Show resolved Hide resolved
nncf/quantization/algorithms/accuracy_control/evaluator.py Show resolved Hide resolved
tests/cross_fw/shared/command.py Show resolved Hide resolved
tests/cross_fw/shared/helpers.py Outdated Show resolved Hide resolved
@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Nov 20, 2024

@AlexanderDokuchaev, feel free to merge after approval from the other reviewers.

@KodiaqQ KodiaqQ dismissed their stale review November 20, 2024 16:19

Not blocking merge.

@KodiaqQ KodiaqQ removed their request for review November 20, 2024 16:20
@alexsu52 alexsu52 mentioned this pull request Nov 26, 2024
Merged
@alexsu52 alexsu52 merged commit b1ea59d into openvinotoolkit:develop Dec 4, 2024
14 checks passed
AlexanderDokuchaev pushed a commit that referenced this pull request Dec 4, 2024
@alexsu52
[DevEx] Fix for make pre-commit (#3114)
ba13df4 
### Changes

added datasets to the known third party for isort

### Reason for changes

Improve DevEx

### Related tickets

#3091

### Tests

N/A
@AlexanderDokuchaev AlexanderDokuchaev mentioned this pull request Dec 15, 2024
Merged
KodiaqQ pushed a commit that referenced this pull request Dec 17, 2024
@AlexanderDokuchaev
[GHA] bandit (#3144)
1b4c9e6 
### Changes

- Add sdl.yml with bandit check (version and config like in jenkins job)
- Use defusedxml instead of xml 
- Return #noseq inxamples (was deleted by mistake in
#3091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodiaqQ KodiaqQ KodiaqQ left review comments

@daniil-lyakhov daniil-lyakhov daniil-lyakhov approved these changes

@kshpv kshpv kshpv approved these changes

@MaximProshin MaximProshin MaximProshin approved these changes

@alexsu52 alexsu52 alexsu52 approved these changes

@andrey-churkin andrey-churkin Awaiting requested review from andrey-churkin

Assignees

@alexsu52 alexsu52

Labels
NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlexanderDokuchaev @MaximProshin @KodiaqQ @alexsu52 @kshpv @daniil-lyakhov