[TORCH FX] Fix Impure Node Removal #3077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1026,7 +1026,7 @@ def _merge_node_and_bias(model: torch.fx.GraphModule, is_target_node: Callable[[ | |||
| is_impure = lambda node: node in nodes_connected_to_output | |||
|
|
|||
| for node in reversed(model.graph.nodes): | |||
| if not is_impure(node) and len(node.users) == 0: | |||
| if not (is_impure(node) or node.op == "placeholder") and len(node.users) == 0: | |||
There was a problem hiding this comment.
Please add a small test case for the updated code
|
@anzr299, please squash your comments and rebase |
|
#3027 Fixes this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ignore placeholder nodes when checking for nodes to eliminate in
_merge_node_and_biasfunction to ensure compatiability with Stable Diffusion models.Reason for changes
Ignore
placeholdernodes to ensure models that are exported with unused inputs are also considered.