Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TorchFX] Bias fusing is removed from default transformations #3027

Merged
merged 3 commits into from
Dec 4, 2024
Merged

[TorchFX] Bias fusing is removed from default transformations #3027

merged 3 commits into from
Dec 4, 2024

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Oct 18, 2024 •
edited
Loading

Changes

  • Bias fusing is removed from default transformations
  • constant_folding is updated to remove inplace operations without users
  • extract_model is updated to support original model output as a subgraph output

Reason for changes

To make it possible to apply quantization the same way it done by X86Quantizer

Related tickets

#2766
110985

Tests

  • All int8 references are updated and checked manually
  • test_constant_folding and test_constant_folding_with_constraints are updated with a constant subgraph which contains an inplace op (relu_)
  • test_model_extraction_with_original_output is introduced
  • conformance test post_training_quantization/557 have finished successfully

@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch experimental NNCF PTQ Pull requests that updates NNCF PTQ labels Oct 18, 2024
@daniil-lyakhov daniil-lyakhov force-pushed the dl/fx/dont_touch_biases branch from cdb74ae to 24eef9f Compare October 21, 2024 13:20
@daniil-lyakhov daniil-lyakhov force-pushed the dl/fx/dont_touch_biases branch 3 times, most recently from 5cbea60 to 66dbc45 Compare November 25, 2024 14:09
@daniil-lyakhov daniil-lyakhov force-pushed the dl/fx/dont_touch_biases branch from 7749878 to b7c9e2e Compare November 25, 2024 14:53
@daniil-lyakhov daniil-lyakhov changed the title WIP [TorchFX] Bias fusing is removed from default transformations [TorchFX] Bias fusing is removed from default transformations Nov 25, 2024
@daniil-lyakhov daniil-lyakhov marked this pull request as ready for review November 25, 2024 14:54
@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner November 25, 2024 14:54
@daniil-lyakhov
Copy link
Collaborator Author

daniil-lyakhov commented Nov 25, 2024 •
edited
Loading

@anzr299, I believe this should fix the #3077, please check. Test: d8b8a60

@daniil-lyakhov daniil-lyakhov mentioned this pull request Nov 28, 2024
Open
@alexsu52 alexsu52 merged commit b7326d0 into openvinotoolkit:develop Dec 4, 2024
14 checks passed
@anzr299 anzr299 mentioned this pull request Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anzr299 anzr299 anzr299 approved these changes

@alexsu52 alexsu52 alexsu52 approved these changes

Assignees
No one assigned
Labels
experimental NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniil-lyakhov @alexsu52 @anzr299