-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Mac CI #690
Fix Mac CI #690
Conversation
This is the PR that fixed it: conan-io/conan-center-index#18447 so it's the
From what I can tell, it's no issue to bump to the latest revision. But I'll have to rebuild and host some binaries manually (for eg CCI doesn't have Visual Studio version 17 binaries) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest for now we make it global (same gmp on all platforms) with a TODO to remove the pinning once this is no longer needed
Haha, of course windows refuses to build that gmp version. I'm tired of this stuff! |
Thanks @macumber |
if(WIN32) | ||
set(CONAN_GMP "") | ||
else() | ||
set(CONAN_GMP "gmp/6.2.1#560eab30a8f52beae2cef5ff26cdd61c") | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note, but setting the variable to empty is unnecessary.
if(NOT WIN32)
set(CONAN_GMP "gmp/....")
endif()
Fixes #689
@jmarrec I think the better approach would be to upload the new gmp recipe to NREL but I don't have permissions to do that. What do you think we should do?