-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional output to run tab #496
Conversation
…d consider removing the socket and just use stdout
I resolved the merge conflicts, will let CI run and give it a test then merge. |
I tried the installer from 9ccc0b7. The simulation did not run and the OSApp looked "just fine" when really the CLI, which is 3.3.0 on this one and does not yet have these new I think we should really check exit code / exit status on OpenStudioApplication/src/openstudio_lib/RunTabView.cpp Lines 181 to 197 in b286ab8
|
… and socket at the same time (not supported)
You can't pass both |
63fcb32
to
8181ad8
Compare
5858565
to
22a0a3d
Compare
…tyle everything, but won't be using it as default since the E+ status updates aren't live (missing a flush in os CLI / workflow gem probably)
It looks like you moved this to #513, is that right? |
Add additional arguments to the run command, needs OS 3.4.0.
We should consider removing the socket and just use QProcess::readyReadStandardOutput(), might remove need for #484
Fixes #110
Fixes #437