Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to see errors generated in ModelToIdf job in App #110

Closed
macumber opened this issue Feb 28, 2014 · 11 comments · Fixed by #513
Closed

Hard to see errors generated in ModelToIdf job in App #110

macumber opened this issue Feb 28, 2014 · 11 comments · Fixed by #513
Labels
Enhancement Request New feature or request

Comments

@macumber
Copy link
Collaborator

You have to go to the tree, right click the job and do show errors and warnings. Seems like these should get printed to the screen as well

2-28-2014 2-14-52 pm

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 29, 2017

Original image is irrelevant to the current design of OS 2.x. But I'd still like in 2.x to be able to easily see these warnings.

@evanweaver
Copy link

Confirm by making model which has known warnings in the forward translation process, and seeing if they are output on the run tab. @macumber any idea if this is still valid?

@macumber
Copy link
Collaborator Author

The new approach would be for the worflow gem to echo out errors and warnings from idf translation, @evanweaver do you have an osm that reproduces an error? Can you attach that to this issue?

@evanweaver
Copy link

@macumber I do not, but one would be appreciated.

@jmarrec
Copy link
Collaborator

jmarrec commented Jan 13, 2018

IIUC @evanweaver previous post was a directive for someone (me probably) to make a test model. I can whip that up.

@jmarrec
Copy link
Collaborator

jmarrec commented Jan 13, 2018

Here's one OSM that only has a plantLoop, and to which I added an AvailabilityManagerHighTemperatureTurnOff without a sensor node, which generates an error:

https://github.com/NREL/OpenStudio/blob/develop/openstudiocore/src/energyplus/ForwardTranslator/ForwardTranslateAvailabilityManagerHighTemperatureTurnOff.cpp#L57

Warnings when FT using the bindings (1 = Error, 0 = Warn)

[11] OpenStudio-Test(main)> w = ft.translateModel(m)
[openstudio.energyplus.ForwardTranslator] <1> Object of type 'OS:AvailabilityManager:HighTemperatureTurnOff' and named 'Availability Manager High Temperature Turn Off 1' doesn't have a 'Sensor Node' (required)
[utilities.idf.WorkspaceObject] <0> Object of type 'Schedule:Constant' and named 'Always On Discrete', points to an object named OnOff from field 1, but that object cannot be located.
[utilities.idf.WorkspaceObject] <0> Object of type 'Schedule:Constant' and named 'Always Off Discrete', points to an object named OnOff 1 from field 1, but that object cannot be located.
[utilities.idf.WorkspaceObject] <0> Object of type 'Schedule:Constant' and named 'Always On Continuous', points to an object named Fractional from field 1, but that object cannot be located.

The OSM model:

DHWLoopOnly.txt

OS 2.4.0 run tab:

screen shot 2018-01-13 at 1 27 35 am

@jmarrec
Copy link
Collaborator

jmarrec commented Jan 13, 2018

I'm not sure how many warnings can be generated on a large(r) model, but if it's a big number, perhaps we should only echo errors on this tab, but also echo a summary:

"During forward translation, X errors and Y warnings were generated, please refer to #{model_folder}/stdout for detailed information"

@macumber macumber self-assigned this Jan 13, 2018
@evanweaver
Copy link

Thanks @jmarrec

@jmarrec jmarrec self-assigned this Feb 5, 2019
@jmarrec
Copy link
Collaborator

jmarrec commented Mar 19, 2020

This requires modification to the openstudio-workflow-gem to capture stdout.

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 19, 2020

Same underlying issue as NREL/OpenStudio#2941

@macumber
Copy link
Collaborator Author

Looks like this is now available in OS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment