-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buttons on userpages visible after logging out #5199
Comments
Fixes openstreetmap#5199. Displays "Send Message", "Add Friend" and "Unfriend" links (buttons) on user profile page only if user is signed in.
#4920 proposes to split this link/button list into actions and non-actions. Then maybe we can show only non-actions for non-logged users. |
Is there a good reason now to show them? if you use them then you're prompted to login and then you can continue? |
I don't think this will work in the long run. Once we start working on GDPR recommendations, you would have to essentially remove nearly all the links there. The requirement to log in shouldn't determine if a link is shown or not. |
Some of the actions depend on your account state. For example, friend/unfriend depends on if you're already friends with the user, which is impossible to know when not logged in. In this case you can see a link to befriend your own account too, which you'll be able to do after logging in. Undoing that would require gping to the dashboard. |
I think the logic behind this issue is "if you removed Report / Mute, remove them all (Send Message, Add Friend / Unfriend), i.e. this looks unfinished, complete it". |
Did we actually remove report and mute? or were they just never enabled for non-logged in users? The point about friend/unfriend needing to know state is very valid though. |
The report feature was added in commit bdc6add for both logged-in and not-logged-in users. Later, it was restricted to display only for logged-in users. The mute feature was added in commit efc61f1 for logged-in users only. |
On a userpage
https://www.openstreetmap.org/user/test?locale=en
we have buttons like
Send Message
|Add Friend
|Report this User
|Mute this User
and on the same userpage after logging out from above ones we can't see
Report this User
andMute this User
anymorebut we still can see
Send Message
andAdd Friend
.I think these two actions shouldn't be visible either, because they require logging in.
What do you think?
The text was updated successfully, but these errors were encountered: