Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from databaseUsername to databaseAccount and fully use MariaDBAccount #333

Merged
merged 1 commit into from
Mar 12, 2024
Merged

migrate from databaseUsername to databaseAccount and fully use MariaDBAccount #333

merged 1 commit into from
Mar 12, 2024

Conversation

zzzeek
Copy link
Contributor

@zzzeek zzzeek commented Mar 9, 2024

Lead Jira: OSPRH-4095

  1. controller calls EnsureMariaDBAccount up front to make sure MariaDBAccount is present
  2. error code from EnsureMariaDBAccount is handled, Conditions are amended when error is returned
  3. controller calls NewDatabaseForAccount instead of NewDatabase
  4. GetAccountAndSecret is used to retrieve account /secret to populate template
  5. GetDatabaseByName() , normally used for delete finalizers, replaced with GetDatabaseByNameAndAccount
  6. CreateOrPatchAll() used to patch the Database, replacing CreateOrPatchDB / CreateOrPatchDBByName
  7. controller calls DeleteUnusedMariaDBAccountFinalizers when launched pods are definitely running on a new MariaDBAccount, returns error code if present
  8. PasswordSelectors that refer to database are removed
  9. all databaseUser replaced with databaseAccount inside of all XYZ_types.go
  10. all databaseUser replaced with databaseAccount inside of all kuttl/*.yaml
  11. all default databaseUser names become databaseAccount, replacing underscores with dashes inside of all XYZ_types.go
  12. all default databaseUser names become databaseAccount, replacing underscores with dashes inside of all kuttl/*.yaml
  13. MariaDBAccountSuiteTests are used in controller ginkgo tests if it has them
  14. 184 is merged and replaces from go.mod are removed

@openshift-ci openshift-ci bot requested review from paramite and viroel March 9, 2024 21:43
@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 9, 2024

/retest

1 similar comment
@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 10, 2024

/retest

@raukadah
Copy link

/test precommit-check

@jlarriba jlarriba mentioned this pull request Mar 11, 2024
Merged
@raukadah
Copy link

/test telemetry-operator-build-deploy
/test telemetry-operator-build-deploy-kuttl
/test images

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from 80f688c to eb8e5ed Compare March 11, 2024 13:32
@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 11, 2024

/retest

1 similar comment
@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 11, 2024

/retest

@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 11, 2024

cc @csibbitt @jlarriba this is ready for merge.

vyzigold
vyzigold approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@vyzigold vyzigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thank you

@openshift-ci openshift-ci bot added the lgtm label Mar 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vyzigold, zzzeek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 987fd95 into openstack-k8s-operators:main Mar 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzigold vyzigold vyzigold approved these changes

@paramite paramite Awaiting requested review from paramite

@viroel viroel Awaiting requested review from viroel

Assignees

@vyzigold vyzigold

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzzeek @raukadah @vyzigold