-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add functions to support downstream generation of MariaDBAccounts by operators #184
add functions to support downstream generation of MariaDBAccounts by operators #184
Conversation
5de7d76
to
6bd257b
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
attempting to follow steps at: openstack-k8s-operators/glance-operator#426 (comment) source PR: openstack-k8s-operators/mariadb-operator#184
89bcc0f
to
738a135
Compare
738a135
to
89bcc0f
Compare
c0a29b1
to
5cf9420
Compare
5cf9420
to
f7aa1c9
Compare
647dde5
to
de879c4
Compare
…BAccount This will move neutron to fully use MariaDBAccount based on the dev work being done for mariadb-operator: openstack-k8s-operators/mariadb-operator#184 Depends-On: openstack-k8s-operators/openstack-operator#656
i've made updates to the mariadbfuncs so that they make more sense from the outside, deprecated elements are moved outwards to deprecated functions, and redundant variables are not passed in for state we already have. given things are moving fast I am ready for this to merge, it is doing its job at the level of account create, account update, deletion of old accounts, and testing it all via ginkgo functions packaged here, I can continue the related patches based on this logic and get them also ready for merge as they wont need a go.mod replace anymore. |
…BAccount This will move neutron to fully use MariaDBAccount based on the dev work being done for mariadb-operator: openstack-k8s-operators/mariadb-operator#184 Depends-On: openstack-k8s-operators/openstack-operator#656
OK one adjustment is that based on looking at PRs like openstack-k8s-operators/heat-operator#323 I might want to use the pattern I suggested at the end of my comment at https://github.com/openstack-k8s-operators/heat-operator/pull/323/files#r1500046605 . Using that idea, I would remove the GetAccountAndSecret method here and go back to using GetDatabaseByNameAndAccount to get a Database facade , where we'd get both the TLS info from as well as the mariadbaccount and secret |
11cdeae
to
f45119e
Compare
/retest |
f45119e
to
130ff24
Compare
130ff24
to
b00a15b
Compare
b00a15b
to
e4eda38
Compare
/retests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dciabrin, gibizer, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
438dde8
into
openstack-k8s-operators:main
This provides a link to install the mariadb image built against the version in openstack-k8s-operators/mariadb-operator#184. This adds rotatable username/password flow to the mariadb operator with associated client functions to be called in each downstream operator. follows steps at: openstack-k8s-operators/glance-operator#426 (comment)
these changes are to support a phased approach to getting openstack-operator to generate MariaDBAccounts. I have an initial demo for glance that uses these functions
the glance PR is at openstack-k8s-operators/glance-operator#426