Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functions to support downstream generation of MariaDBAccounts by operators #184

Conversation

zzzeek
Copy link
Contributor

@zzzeek zzzeek commented Jan 29, 2024

these changes are to support a phased approach to getting openstack-operator to generate MariaDBAccounts. I have an initial demo for glance that uses these functions

the glance PR is at openstack-k8s-operators/glance-operator#426

@zzzeek
Copy link
Contributor Author

zzzeek commented Feb 2, 2024

/retest

Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from 647dde5 to de879c4 Compare February 22, 2024 19:51
zzzeek added a commit to zzzeek/neutron-operator that referenced this pull request Feb 22, 2024
…BAccount

This will move neutron to fully use MariaDBAccount based on the dev work
being done for mariadb-operator:

openstack-k8s-operators/mariadb-operator#184

Depends-On: openstack-k8s-operators/openstack-operator#656
@zzzeek
Copy link
Contributor Author

zzzeek commented Feb 22, 2024

i've made updates to the mariadbfuncs so that they make more sense from the outside, deprecated elements are moved outwards to deprecated functions, and redundant variables are not passed in for state we already have.

given things are moving fast I am ready for this to merge, it is doing its job at the level of account create, account update, deletion of old accounts, and testing it all via ginkgo functions packaged here, I can continue the related patches based on this logic and get them also ready for merge as they wont need a go.mod replace anymore.

cc @dciabrin @gibizer @stuggi

zzzeek added a commit to zzzeek/neutron-operator that referenced this pull request Feb 22, 2024
…BAccount

This will move neutron to fully use MariaDBAccount based on the dev work
being done for mariadb-operator:

openstack-k8s-operators/mariadb-operator#184

Depends-On: openstack-k8s-operators/openstack-operator#656
@zzzeek
Copy link
Contributor Author

zzzeek commented Feb 22, 2024

OK one adjustment is that based on looking at PRs like openstack-k8s-operators/heat-operator#323 I might want to use the pattern I suggested at the end of my comment at https://github.com/openstack-k8s-operators/heat-operator/pull/323/files#r1500046605 . Using that idea, I would remove the GetAccountAndSecret method here and go back to using GetDatabaseByNameAndAccount to get a Database facade , where we'd get both the TLS info from as well as the mariadbaccount and secret

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch 2 times, most recently from 11cdeae to f45119e Compare February 23, 2024 14:54
@zzzeek
Copy link
Contributor Author

zzzeek commented Feb 23, 2024

/retest

api/test/helpers/harnesses.go Outdated Show resolved Hide resolved
api/test/helpers/harnesses.go Show resolved Hide resolved
api/test/helpers/harnesses.go Outdated Show resolved Hide resolved
api/v1beta1/mariadbdatabase_funcs.go Outdated Show resolved Hide resolved
api/v1beta1/mariadbdatabase_funcs.go Show resolved Hide resolved
api/v1beta1/mariadbdatabase_funcs.go Show resolved Hide resolved
api/v1beta1/mariadbdatabase_funcs.go Outdated Show resolved Hide resolved
@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from 130ff24 to b00a15b Compare February 27, 2024 19:38
@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from b00a15b to e4eda38 Compare February 27, 2024 20:15
@gibizer
Copy link
Contributor

gibizer commented Feb 29, 2024

/retests

Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@gibizer
Copy link
Contributor

gibizer commented Feb 29, 2024

/retest

@dciabrin
Copy link
Contributor

dciabrin commented Mar 3, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Mar 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dciabrin, gibizer, zzzeek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 438dde8 into openstack-k8s-operators:main Mar 3, 2024
6 checks passed
zzzeek added a commit to zzzeek/openstack-operator that referenced this pull request Mar 4, 2024
This provides a link to install the mariadb image built
against the version in
openstack-k8s-operators/mariadb-operator#184.

This adds rotatable username/password flow to the mariadb operator
with associated client functions to be called in each downstream
operator.

follows steps at:

openstack-k8s-operators/glance-operator#426 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants