Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placement user creation #102

Merged

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Nov 20, 2023

Currently the placement user does not have a kolla generated uid and it is not in the kolla group:

❯ oc rsh placement-7ccc6bc7f5-cfchj
Defaulted container "placement-api" out of: placement-api, init (init)
sh-5.1# id
uid=0(root) gid=0(root) groups=0(root)
sh-5.1# cat /etc/passwd | grep placement
placement:x:997:994:OpenStack Placement:/:/bin/bash
sh-5.1# cat /etc/group | grep kolla
kolla:x:42400:
sh-5.1# 

This PR will make sure that during build the proper placemenet uid and group membership is used

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/540629f5f71b4d92a8e924927a7752f7

✔️ tcib-build-containers SUCCESS in 1h 37m 30s
tcib-crc-podified-edpm-baremetal FAILURE in 25m 31s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 00m 47s

@gibizer
Copy link
Contributor Author

gibizer commented Nov 20, 2023

recheck unrelated baremetal deploy failure

+ IP_ADDRESS_SUFFIX=5
+ for WORKER in ${WORKERS}
+ cat
+ '[' -n '' ']'
+ cat
+ IP_ADDRESS_SUFFIX=6
+ CTLPLANE_IP_ADDRESS_SUFFIX=11
error: timed out waiting for the condition on nodenetworkconfigurationpolicies/enp6s0-crc-74q6p-master-0
gmake: *** [Makefile:1888: nncp] Error 1

Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks correct to me.
lets see what ci looks like in the morning

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/be8519a81c6d43309cfe490e3201d710

✔️ tcib-build-containers SUCCESS in 1h 43m 33s
tcib-crc-podified-edpm-baremetal FAILURE in 24m 19s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 00m 45s

@gibizer
Copy link
Contributor Author

gibizer commented Nov 21, 2023

recheck
same nncp issue again :/

+ IP_ADDRESS_SUFFIX=5
+ for WORKER in ${WORKERS}
+ cat
+ '[' -n '' ']'
+ cat
+ IP_ADDRESS_SUFFIX=6
+ CTLPLANE_IP_ADDRESS_SUFFIX=11
error: timed out waiting for the condition on nodenetworkconfigurationpolicies/enp6s0-crc-74q6p-master-0
gmake: *** [Makefile:1888: nncp] Error 1

@gibizer
Copy link
Contributor Author

gibizer commented Nov 21, 2023

recheck same nncp issue again :/

+ IP_ADDRESS_SUFFIX=5
+ for WORKER in ${WORKERS}
+ cat
+ '[' -n '' ']'
+ cat
+ IP_ADDRESS_SUFFIX=6
+ CTLPLANE_IP_ADDRESS_SUFFIX=11
error: timed out waiting for the condition on nodenetworkconfigurationpolicies/enp6s0-crc-74q6p-master-0
gmake: *** [Makefile:1888: nncp] Error 1

The baremetal issue should be fixed by this revert openstack-k8s-operators/ci-framework#826

Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci is happy and the change looks correct

this was previously not caught because we are running this container as root and placement is running under apache but this will allow us to run as placement instead.

@viroel
Copy link
Contributor

viroel commented Nov 21, 2023

/approve

Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bogdando, gibizer, SeanMooney, viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f7861cd into openstack-k8s-operators:main Nov 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants