-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run placement service as root #107
Do not run placement service as root #107
Conversation
9cca4f8
to
ba69fb4
Compare
/test precommit-check
|
ba69fb4
to
9bdfd76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/hold This should not work as kolla_set_config should fail. Also we cannot simply switch to the placement user in the container as that user is not in the kolla group:
|
And we have a strange dbsync command:
|
We need a fix in the tcib image first openstack-k8s-operators/tcib#102 |
tcib fix merged but there is still no container image built in https://quay.io/repository/podified-antelope-centos9/openstack-placement-api?tab=tags&tag=latest so we wait... |
container promotion is blocked on https://issues.redhat.com/browse/OSPCIX-119 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.redhat.com/browse/OSPCIX-119 is closed
and there was a successful promotion yesterday
https://review.rdoproject.org/zuul/build/97b34cff01744289b42f01944b777616
so i belive we can now proceed with this
@GIBI if you agree then feel free to drop your hold
9bdfd76
to
7d08fa4
Compare
7d08fa4
to
32decef
Compare
/unhold |
This has the same limitation as nova-operator has. We cannot remove the usage of root from the container as kolla_set_config needs sudo. |
/hold |
I mixed up this needs a new placement-operator to pick up a new placement-api tcib image. But we are in placement-operator so we don't have to wait for that. |
/unhold |
This did not removed the root usage from the init container. We should get rid of the init container instead. (See openstack-k8s-operators#64) Implements: https://issues.redhat.com/browse/OSPRH-1374
32decef
to
0839d9a
Compare
/LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bogdando, gibizer, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8fdff26
into
openstack-k8s-operators:main
Depends-On: openstack-k8s-operators/tcib#102
Implements: https://issues.redhat.com/browse/OSPRH-1374
Depends-On: openstack-k8s-operators/openstack-operator#591 (to pick up a new tcib image)