Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use database helpers from mariadb-operator/api #88

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

gibizer
Copy link
Collaborator

@gibizer gibizer commented Oct 5, 2023

The lib-common/modules/database is moved to mariadb-operator/api to remove a circular dependency.

The lib-common/modules/database is moved to mariadb-operator/api to
remove a circular dependency.
Copy link
Collaborator

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the repeace line has been removed and you have bumped to the new API version of mariadb operator i assume the dep has been merged there so approving this now

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SeanMooney
Copy link
Collaborator

openstack-k8s-operators/mariadb-operator#156 was the dep and that has merged

@gibizer
Copy link
Collaborator Author

gibizer commented Oct 5, 2023

/test placement-operator-build-deploy-kuttl

Error from server (BadRequest): unable to wait for build openstack-operator-bundle-1 to run: timed out waiting for the condition

@openshift-ci openshift-ci bot merged commit 669a438 into openstack-k8s-operators:main Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants