Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move database module content from lib-common to /api #156

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Sep 29, 2023

This is needed to resolve a circular dependency.

This is needed to resolve a circular dependency.
@openshift-ci openshift-ci bot requested review from dprince and stuggi September 29, 2023 12:31
@gibizer
Copy link
Contributor Author

gibizer commented Sep 29, 2023

/hold I need to test this

@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/retest fixed cert manager issue

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

@gibizer: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test images
  • /test mariadb-operator-build-deploy-kuttl
  • /test precommit-check
  • /test unit

The following commands are available to trigger optional jobs:

  • /test mariadb-operator-build-deploy

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openstack-k8s-operators-mariadb-operator-main-images
  • pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy-kuttl
  • pull-ci-openstack-k8s-operators-mariadb-operator-main-precommit-check
  • pull-ci-openstack-k8s-operators-mariadb-operator-main-unit

In response to this:

/retest fixed cert manager issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/retest
cert manager issue is fixed

@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/test mariadb-operator-build-deploy-kuttl

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@gibizer
Copy link
Contributor Author

gibizer commented Oct 3, 2023

/unhold
There are example adaptation PRs (nova, keystone) showing that this works

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the conversation on slack, I think it's a good idea keeping the functions used for envTests aligned w/ the API, so we can see consistency between envTests execution and a job when we bump the api dependency that we include on a different operator.
+1 from me

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, gibizer, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2023
@openshift-ci openshift-ci bot merged commit efbae20 into openstack-k8s-operators:main Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants