Correct placement flow to expose service only when deployment is ready #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibizer
reviewed
May 28, 2024
mrkisaolamb
force-pushed
the
correct-check
branch
from
50db196 to
034c332
Compare
|
This patch hit similarr issue like nova and tests timeouts when wait for correct state in db so I bump up timeout for tests |
mrkisaolamb
force-pushed
the
correct-check
branch
from
034c332 to
edd7b96
Compare
bogdando
reviewed
Jun 6, 2024
| // Only expose the service is the deployment succeeded | ||
| if !instance.Status.Conditions.IsTrue(condition.DeploymentReadyCondition) { | ||
| Log.Info("Waiting for the Deployment to become Ready before exposing the sevice in Keystone") | ||
| return ctrl.Result{}, nil |
There was a problem hiding this comment.
shouldn't we requeue, or will we get another event to retrigger this, once things get ready?
There was a problem hiding this comment.
we are watching the Deployment so there will be an automatic reconcile when the deployment status changes.
gibizer
approved these changes
Jun 6, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0863f22
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: openstack-k8s-operators/mariadb-operator#222