Add method to bump generation in tests #222
Conversation
api/test/helpers/harnesses.go
Outdated
| @@ -69,6 +73,7 @@ func (harness *MariaDBTestHarness) Setup( | |||
| mariadb *TestHelper, | |||
| timeout time.Duration, | |||
| interval time.Duration, | |||
| runUpdateOptional ...bool, | |||
There was a problem hiding this comment.
could we just create a logic in Setup that if UpdateGenerationCR is not provided then we don't run it? We should be able to check if UpdateGenerationCR is a real function or some golang default.
There was a problem hiding this comment.
So if not provided the func var will be nil so we can simply check for nil before running it and we dont need to change the signature of Setup. https://go.dev/play/p/oj808HE7Jj8
api/test/helpers/harnesses.go
Outdated
| harness.UpdateAccount(newAccountName) | ||
| harness.mariaDBHelper.SimulateMariaDBAccountCompleted(newAccountName) | ||
|
|
||
| if harness.runUpdate { | ||
| harness.UpdateGenerationCR() | ||
| } |
There was a problem hiding this comment.
I'm trying to find a better, more generic name for UpdateGenerationCR. As far as I understand the generic logic is that the account is updated and the made ready and then the service CR using the account needs to roll out the usage of the new account and then the finalizer removed from the old account. The impl of rolling out the usage of the new account is now requires extra steps as the service CR can only remove the finalizer if the new generation of the statefulset is ready. So based on that I would name this hook "UseNewAccount" or "SwitchToNewAccount"
In nova we need SimulateDeploymentReplicaReady call after SimulateMariaDBAccountCompleted(newAccountName) too be able reconcile NovaCr. Changes is needed because we added observeGeneration into subCrs and now readines logic depend on generations.
mrkisaolamb
force-pushed
the
update_harness_test
branch
from
0c8cfdd to
0c306d2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrkisaolamb, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test mariadb-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit b02b9f3
into
openstack-k8s-operators:main
In nova we need SimulateDeploymentReplicaReady
call after SimulateMariaDBAccountCompleted(newAccountName) too be able reconcile NovaCr. Changes is needed
because we added observeGeneration into subCrs
and now readines logic depend on generations.