Fix RabbitMQ image default/override logic

[abays]

We were always setting the default for the RabbitMQ image, even if the user had provided an explicit image

[olliewalsh]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abays,olliewalsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d41d631d357d4907ac8ecfd20fd69490

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 15s
❌ podified-multinode-edpm-deployment-crc FAILURE in 41m 22s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 27m 59s

[abays]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/002134e183fe478f918b295ba8535c39

✔️ openstack-k8s-operators-content-provider SUCCESS in 57m 10s
❌ podified-multinode-edpm-deployment-crc FAILURE in 41m 51s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 18m 18s

[openshift-ci]

New changes are detected. LGTM label has been removed.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/47b96f92e8dc4f48b13551c738f915c9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 22s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 53m 28s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 31m 29s

[abays]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ac4c1c90c89446d19f3da3be4c3e2df3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 58s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 55m 32s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 27m 10s

[abays]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6ebae0146af04953ad614a28b616c3df

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 04m 36s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 49m 16s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 45m 03s

[abays]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7daab3c076344b6aaf5f4fe552795636

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 04m 10s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 48m 52s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 37m 10s

[abays]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ea1693a3de954acd955758572f419189

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 17m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 51m 56s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 59m 05s

[abays]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a15f90dab3404a5f8ab81b87f891e0f7

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 17m 20s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 51m 43s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 59m 53s

[abays]

recheck

This keeps failing with hiccups on the cifmw-crc-podified-edpm-baremetal job. One last try and then I'm overriding because we need this fix.

[openshift-ci]

@abays: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/openstack-operator-build-deploy-kuttl	cc93e92	link	unknown	/test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[abays]

The ci/prow/openstack-operator-build-deploy-kuttl Prow job passed previously and no changes have been made to this PR since then. Ignoring the failure.