Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override default rabbmitq image for periodic CI #155

Conversation

marios
Copy link
Contributor

@marios marios commented Sep 14, 2023

This adds the rabbmitmq and rabbmitmq-cell1 image override so we use the right registry, namespace and tag under test in the periodic job.

@marios marios marked this pull request as draft September 14, 2023 10:47
@marios
Copy link
Contributor Author

marios commented Sep 21, 2023

going to rebase so update incoming.
I still have draft on this because we are still not successfully overriding the rabbit container

Andrew posted a fix which is needed first there openstack-k8s-operators/openstack-operator#475

This adds the rabbmitmq and rabbmitmq-cell1 image override so we use
the right registry, namespace and tag under test in the periodic job.
@marios marios force-pushed the fix_rabbit_default_periodic_container branch from 94e356f to 68fc680 Compare September 21, 2023 08:20
@marios marios marked this pull request as ready for review September 22, 2023 08:22
@marios
Copy link
Contributor Author

marios commented Sep 22, 2023

@jistr @fao89 @cescgina hi folks please have a look when you get some time we can merge this now

after the fix at openstack-k8s-operators/openstack-operator#475 merged we can now override the rabbit image.

Here in the pull request, it defaults to quay.io/current-podified:

        * https://logserver.rdoproject.org/55/155/68fc680ea521ac3f8d573c9437c346682a88334d/github-check/data-plane-adoption-github-rdo-centos-9-crc-single-node/8ae277a/controller/pod/rabbitmq-server-0-describe.txt
        *     Image:         quay.io/podified-antelope-centos9/openstack-rabbitmq@sha256:fdd6a92fe08d0e50257e9197b13a819519b121c59e5878dbbe38baa430b8d161

And in the periodic/rdo test it takes quay.rdoproject.org with the specified hash (podified-ci-testing)

        * https://logserver.rdoproject.org/02/49902/11/check/periodic-data-plane-adoption-github-rdo-centos-9-crc-single-node-antelope/69a89ea/controller/pod/rabbitmq-server-0-describe.txt
        *     Image:         quay.rdoproject.org/podified-antelope-centos9/openstack-rabbitmq:b8b74533a641e5669a7a663e06aa0b1d

@jistr jistr merged commit 1b391e0 into openstack-k8s-operators:main Sep 22, 2023
@marios marios deleted the fix_rabbit_default_periodic_container branch September 25, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants