Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to golang 1.21 and k8s to 1.29 #1075

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Sep 16, 2024

@stuggi
Copy link
Contributor Author

stuggi commented Sep 16, 2024

/retest

@bshephar
Copy link
Contributor

Seems to have been an issue with Telemetry here:

lastTransitionTime: "2024-09-16T16:07:39Z"
message: OpenStackControlPlane Telemetry in progress
reason: Requested
severity: Info
status: "False"
type: Ready
lastTransitionTime: "2024-09-16T16:07:32Z"
message: OpenStackControlPlane Telemetry in progress
reason: Requested
severity: Info
status: "False"
type: OpenStackControlPlaneTelemetryReady
❯ curl -s "https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openstack-k8s-operators_openstack-operator/1075/pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl/1835695758297272320/artifacts/openstack-operator-build-deploy-kuttl/openstack-k8s-operators-gather/artifacts/must-gather/quay-io-openstack-k8s-operators-openstack-must-gather-sha256-3d1f620ae3617fbd6371f55aa948b34e9daf31a461d3c557cf1a7c2db38d0385/namespaces/openstack-kuttl-tests/crs/telemetries.telemetry.openstack.org/telemetry.yaml" | yq '.status.conditions'
- lastTransitionTime: "2024-09-16T16:07:18Z"
  message: Deployment not started
  reason: Init
  status: Unknown
  type: Ready
- lastTransitionTime: "2024-09-16T16:07:18Z"
  message: Deployment not started
  reason: Init
  status: Unknown
  type: CeilometerReady

But the operator does report that it reconciled it successfully:

❯ curl -s "https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openstack-k8s-operators_openstack-operator/1075/pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl/1835695758297272320/artifacts/openstack-operator-build-deploy-kuttl/openstack-k8s-operators-gather/artifacts/must-gather/quay-io-openstack-k8s-operators-openstack-must-gather-sha256-3d1f620ae3617fbd6371f55aa948b34e9daf31a461d3c557cf1a7c2db38d0385/namespaces/openstack-operators/pods/telemetry-operator-controller-manager-7d78579cf7-4qb5f/logs/manager.log" | tail -n 1
2024-09-16T16:07:18Z    INFO    Controllers.Ceilometer  Reconciled Service successfully {"controller": "ceilometer", "controllerGroup": "telemetry.openstack.org", "controllerKind": "Ceilometer", "Ceilometer": {"name":"ceilometer","namespace":"openstack-kuttl-tests"}, "namespace": "openstack-kuttl-tests", "name": "ceilometer", "reconcileID": "79781000-6d9c-4261-9e74-84fc53e11372"}

Let's re-run and see if this reproduces.

@bshephar
Copy link
Contributor

/test openstack-operator-build-deploy-kuttl

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c85f6c658b6d4b799b923b88d08cb00c

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 12m 24s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 43s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 46s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 39m 16s
openstack-operator-tempest-multinode FAILURE in 1h 08m 33s

@dprince
Copy link
Contributor

dprince commented Sep 17, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/14b74cc836954114921b5208892d11e7

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 47m 41s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 38s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 33m 53s
openstack-operator-tempest-multinode FAILURE in 1h 10m 45s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1915fa65ff114fa089b4d42257ec97b7

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 09m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 31s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 23m 22s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 45m 00s
openstack-operator-tempest-multinode FAILURE in 1h 08m 23s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ce7c683e9bc1469a8a0f85dacd186816

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 37m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 14s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 21m 35s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 30m 46s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 33m 31s

@bshephar
Copy link
Contributor

recheck

@stuggi
Copy link
Contributor Author

stuggi commented Sep 19, 2024

rebased

@stuggi
Copy link
Contributor Author

stuggi commented Sep 22, 2024

recheck

@stuggi
Copy link
Contributor Author

stuggi commented Sep 22, 2024

/retest-required

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/59d3d8d2ebbc4ba28be76a7ef3c4ea1f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 54m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 02s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 22m 12s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 38m 02s
openstack-operator-tempest-multinode FAILURE in 1h 40m 32s

@stuggi
Copy link
Contributor Author

stuggi commented Sep 23, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/84444e904a174128a53de14b262a0a20

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 47m 33s
podified-multinode-edpm-deployment-crc FAILURE in 1h 40m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 36s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 35m 31s
openstack-operator-tempest-multinode FAILURE in 1h 36m 27s

@stuggi
Copy link
Contributor Author

stuggi commented Sep 23, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f0c1f573980247cc837e33b4158668a2

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 08m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 49s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 32s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 37m 01s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 33m 46s

@stuggi
Copy link
Contributor Author

stuggi commented Sep 23, 2024

recheck

Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bshephar
Copy link
Contributor

harness.go:278: Successful connection to cluster at: https://api.oko-08.oooci.ccitredhat.com:6443/
    logger.go:42: 18:28:34 |  | running command: [oc apply -n openstack-kuttl-tests -f https://raw.githubusercontent.com/openstack-k8s-operators/infra-operator/main/config/samples/network_v1beta1_netconfig.yaml]
    logger.go:42: 18:28:34 |  | Error from server (InternalError): error when creating "https://raw.githubusercontent.com/openstack-k8s-operators/infra-operator/main/config/samples/network_v1beta1_netconfig.yaml": Internal error occurred: failed calling webhook "mnetconfig.kb.io": failed to call webhook: Post "[https://infra-operator-controller-manager-service.openstack-operators.svc:443/mutate-network-openstack-org-v1beta1-netconfig?timeout=10s](https://infra-operator-controller-manager-service.openstack-operators.svc/mutate-network-openstack-org-v1beta1-netconfig?timeout=10s)": no endpoints available for service "infra-operator-controller-manager-service"

Let's recheck it

@bshephar
Copy link
Contributor

/test openstack-operator-build-deploy-kuttl

* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v1.59.1 (1.60 >= golang 1.22; 1.61 >= golang 1.23)
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.21-sdk-1.31

Jira: OSPRH-6501

Signed-off-by: Martin Schuppert <[email protected]>
Signed-off-by: Martin Schuppert <[email protected]>
* Bump k8s api, apimachinery, client-go to 0.29
* bump controller-runtime to 0.17
* change github.com/openshift/api to match latest commit for release-4.16 branch
* update ENVTEST_K8S_VERSION to 1.29 match with k8s version

Signed-off-by: Martin Schuppert <[email protected]>
When the golang version does not match the version used inside
the build container, dowloading the modules can fail with:

~~~
go: go.work requires go >= 1.21.13 (running go 1.21.11; GOTOOLCHAIN=local)
~~~

This PR makes set the GOTOOLCHAIN to set 1.21.0 as the min required
version and sets it in go.work file.

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi
Copy link
Contributor Author

stuggi commented Sep 24, 2024

/retest

@stuggi
Copy link
Contributor Author

stuggi commented Sep 24, 2024

rebased

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9c74cce8023b4e149be4b64ab4c5640f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 47m 42s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 51s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 23s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 35m 51s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 45m 10s

@stuggi
Copy link
Contributor Author

stuggi commented Sep 24, 2024

recheck

Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 24, 2024
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, dprince, olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bshephar,dprince,olliewalsh,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 4d3b73d link unknown /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@olliewalsh olliewalsh merged commit bcfe7b3 into openstack-k8s-operators:main Sep 24, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants