-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to golang 1.21 and k8s to 1.29 #1075
Conversation
/retest |
Seems to have been an issue with Telemetry here:
But the operator does report that it reconciled it successfully:
Let's re-run and see if this reproduces. |
/test openstack-operator-build-deploy-kuttl |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c85f6c658b6d4b799b923b88d08cb00c ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 12m 24s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/14b74cc836954114921b5208892d11e7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 47m 41s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1915fa65ff114fa089b4d42257ec97b7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 09m 51s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ce7c683e9bc1469a8a0f85dacd186816 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 37m 55s |
recheck |
rebased |
recheck |
/retest-required |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/59d3d8d2ebbc4ba28be76a7ef3c4ea1f ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 54m 13s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/84444e904a174128a53de14b262a0a20 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 47m 33s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f0c1f573980247cc837e33b4158668a2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 08m 18s |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Let's recheck it |
/test openstack-operator-build-deploy-kuttl |
* bump in go.mod (base and api) * bump go-toolset in Dockerfile * bump in github jobs ('.github/workflows') * Bump the golangci-lint version in the .pre-commit-config.yaml to v1.59.1 (1.60 >= golang 1.22; 1.61 >= golang 1.23) * Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.21-sdk-1.31 Jira: OSPRH-6501 Signed-off-by: Martin Schuppert <[email protected]>
Signed-off-by: Martin Schuppert <[email protected]>
* Bump k8s api, apimachinery, client-go to 0.29 * bump controller-runtime to 0.17 * change github.com/openshift/api to match latest commit for release-4.16 branch * update ENVTEST_K8S_VERSION to 1.29 match with k8s version Signed-off-by: Martin Schuppert <[email protected]>
When the golang version does not match the version used inside the build container, dowloading the modules can fail with: ~~~ go: go.work requires go >= 1.21.13 (running go 1.21.11; GOTOOLCHAIN=local) ~~~ This PR makes set the GOTOOLCHAIN to set 1.21.0 as the min required version and sets it in go.work file. Signed-off-by: Martin Schuppert <[email protected]>
/retest |
rebased |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9c74cce8023b4e149be4b64ab4c5640f ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 47m 42s |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, dprince, olliewalsh, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@stuggi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
bcfe7b3
into
openstack-k8s-operators:main
Jira: https://issues.redhat.com//browse/OSPRH-6501