Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to golang 1.21 and k8s to 1.29 #276

Merged
merged 3 commits into from
Sep 24, 2024
Merged

bump to golang 1.21 and k8s to 1.29 #276

merged 3 commits into from
Sep 24, 2024

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Sep 17, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested review from abays and olliewalsh September 17, 2024 07:17
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a916e5dc676349b98d72175916763820

❌ openstack-k8s-operators-content-provider FAILURE in 9m 22s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi
Copy link
Contributor Author

stuggi commented Sep 17, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3ac21270fde54a1db8f1df3625bee29d

❌ openstack-k8s-operators-content-provider FAILURE in 7m 51s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi stuggi mentioned this pull request Sep 17, 2024
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8a50b2aa5d8e456395123b32c043ea1b

❌ openstack-k8s-operators-content-provider FAILURE in 10m 16s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi
Copy link
Contributor Author

stuggi commented Sep 17, 2024

recheck

@stuggi
bump to golang 1.21
6d19cf7 
* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v1.59.1 (1.60 >= golang 1.22; 1.61 >= golang 1.23)
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.21-sdk-1.31

Jira: OSPRH-6501

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi
Bump k8s api to match OCP 4.16
8023111 
* Bump k8s api, apimachinery, client-go to 0.29
* bump controller-runtime to 0.17
* change github.com/openshift/api to match latest commit for release-4.16 branch
* update ENVTEST_K8S_VERSION to 1.29 match with k8s version

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi
set GOTOOLCHAIN min version when init go.work
d1e7b4e 
When the golang version does not match the version used inside
the build container, dowloading the modules can fail with:

~~~
go: go.work requires go >= 1.21.13 (running go 1.21.11; GOTOOLCHAIN=local)
~~~

This PR makes set the GOTOOLCHAIN to set 1.21.0 as the min required
version and sets it in go.work file.

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi
Copy link
Contributor Author

stuggi commented Sep 24, 2024

/retest-required

@stuggi stuggi requested review from dprince and bshephar September 24, 2024 14:28
olliewalsh
olliewalsh approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ab5ffca into openstack-k8s-operators:main Sep 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliewalsh olliewalsh olliewalsh approved these changes

@abays abays Awaiting requested review from abays

@dprince dprince Awaiting requested review from dprince

@bshephar bshephar Awaiting requested review from bshephar

Assignees

@olliewalsh olliewalsh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuggi @olliewalsh