Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use the new lib-common/common/log interface" #210

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Jan 5, 2023

Reverts #206 as it was depending on a forked lib-common

@openshift-ci openshift-ci bot requested review from kk7ds and SeanMooney January 5, 2023 13:29
@openshift-ci openshift-ci bot added the approved label Jan 5, 2023
@gibizer
Copy link
Contributor Author

gibizer commented Jan 5, 2023

pre-commit.ci run

@@ -111,8 +111,6 @@ github.com/flowstack/go-jsonschema v0.1.1/go.mod h1:yL7fNggx1o8rm9RlgXv7hTBWxdBM
github.com/fsnotify/fsnotify v1.5.4 h1:jRbGcIw6P2Meqdwuo0H1p6JVLbL5DHKAKlYndzMwVZI=
github.com/fsnotify/fsnotify v1.5.4/go.mod h1:OVB6XrOHzAwXMpEM7uPOzcehqUV2UqJxmVXmkdnm1bU=
github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04=
github.com/gibizer/lib-common/modules/common v0.0.0-20221219140315-47b042183a5b h1:J7HneemRRPUAFpBUxlTEIXQ3za4J/kUwpSwWf8fNchw=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack we should loop back to if we need to have ci to block this at some point but for now we can just review for it.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jan 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2023

New changes are detected. LGTM label has been removed.

@gibizer
Copy link
Contributor Author

gibizer commented Jan 6, 2023

/lgtm
It was just a trivial rebase

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2023

@gibizer: you cannot LGTM your own PR.

In response to this:

/lgtm
It was just a trivial rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gibizer gibizer added the lgtm label Jan 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 72619e7 into master Jan 6, 2023
@gibizer gibizer deleted the revert-206-new-logging-interface branch January 6, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants