-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new lib-common/common/log interface #206
Use the new lib-common/common/log interface #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I get the comments for dependency patch correct, we should rework this to just use log.FromContext(ctx) ?
please disregard... that's exaclty what you are already doing here :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bogdando, gibizer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bogdando not sure if you wanted to merge this ? the go.mod references a test lib-common branch from gibi |
No, I've missed that auto-merge feature. All I wanted is to remove the "requires changes" mark set by me earlier :( |
Shall we revert or wait for openstack-k8s-operators/lib-common#125 to become merged. Sorry for unexpected auto-merge |
It is a Draft as only the nova controller is switched over to the new interface.
Depends-on: openstack-k8s-operators/lib-common#125