Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new lib-common/common/log interface #206

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Dec 19, 2022

It is a Draft as only the nova controller is switched over to the new interface.

Depends-on: openstack-k8s-operators/lib-common#125

Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I get the comments for dependency patch correct, we should rework this to just use log.FromContext(ctx) ?

@bogdando
Copy link
Contributor

bogdando commented Jan 2, 2023

So if I get the comments for dependency patch correct, we should rework this to just use log.FromContext(ctx) ?

please disregard... that's exaclty what you are already doing here :)

@openshift-ci openshift-ci bot added the lgtm label Jan 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bogdando, gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 293f5b8 into openstack-k8s-operators:master Jan 2, 2023
@stuggi
Copy link
Contributor

stuggi commented Jan 2, 2023

@bogdando not sure if you wanted to merge this ? the go.mod references a test lib-common branch from gibi

@bogdando
Copy link
Contributor

bogdando commented Jan 2, 2023

No, I've missed that auto-merge feature. All I wanted is to remove the "requires changes" mark set by me earlier :(

@bogdando
Copy link
Contributor

bogdando commented Jan 4, 2023

Shall we revert or wait for openstack-k8s-operators/lib-common#125 to become merged. Sorry for unexpected auto-merge

@gibizer gibizer deleted the new-logging-interface branch May 31, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants