Delete infra test helpers #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
This is necessary to remove a dependency cycle. The helpers are moved to infra-operator/apis module.
gibizer
force-pushed
the
infra-test-helpers
branch
from
08cdb1c to
cee2ffc
Compare
|
keystone was the last one, we can unblock this patch now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to remove a dependency cycle. The helpers are moved to infra-operator/apis module.
PR merging order:
- Move infra test helpers from lib-common to /apis infra-operator#127
- [envtest]note that test helpers are moved dev-docs#64