Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move infra test helpers from lib-common to /apis #127

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Move infra test helpers from lib-common to /apis #127

merged 1 commit into from
Oct 1, 2023

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Sep 29, 2023

This is necessary to remove a dependency cycle

@gibizer
Move infra test helpers from lib-common to /apis
cb8446b 
This is necessary to remove a dependency cycle
@gibizer
Copy link
Contributor Author

gibizer commented Sep 29, 2023

/hold I need to test this

@openshift-ci openshift-ci bot requested review from lewisdenny and stuggi September 29, 2023 08:37
@gibizer gibizer mentioned this pull request Sep 29, 2023
Merged
11 tasks
@gibizer
Copy link
Contributor Author

gibizer commented Sep 29, 2023

/unhold

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/17bb3ebc353a4012b6fc8a57cf0331ed

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 29m 16s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 52m 39s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 23m 07s

@gibizer
Copy link
Contributor Author

gibizer commented Sep 29, 2023

recheck

stuggi
stuggi approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit e930a05 into openstack-k8s-operators:main Oct 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuggi stuggi stuggi approved these changes

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

Assignees

@stuggi stuggi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gibizer @stuggi @openshift-merge-robot