Remove idrac-wsman drivers from configured list #493
Conversation
steveb
requested review from
juliakreger
and removed request for
olliewalsh and
abays
There was a problem hiding this comment.
Don't we want to keep the idrac-redfish? Only the wsman driver was removed upstream.
The idrac-redfish stuff is still around - https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/drac.py
|
I concur, it likely makes sense to remove idrac-wsman items, but keep idrac-redfish around. That mostly limits scope, and does remove the dell specifics which upstream should continue to strive for, but until the virtual media handling is sorted so just "redfish" works, I suspect it won't be entirely possible to navigate away from idrac-redfish interfaces. |
Dracclient has been removed from the container images[1] and ironic-conductor will not start if wsman drivers are in then enabled list. This change removes them. [1] openstack-k8s-operators/tcib#224
steveb
changed the title
|
Updated to be wsman only |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliakreger, steveb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@steveb: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Dracclient has been removed from the container images[1] and
ironic-conductor will not start if wsman drivers are in then enabled
list. This change removes them.
[1] openstack-k8s-operators/tcib#224
Jira: OSPRH-11193