-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default network interface #492
Fix default network interface #492
Conversation
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/65d4e3d628e74e4e85f8ea3f37b2c225 ✔️ noop SUCCESS in 0s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This will likely need #493 for kuttl to pass
/retest |
1 similar comment
/retest |
The default interface parameter inadvertently set the default for all newly created nodes, unless they otherwise specify a network interface, to be "noop", which is only usable for standalone users. Integrated users want flat, or neutron. Given historical usage pattern, the existing defaults set via "enabled_network_interfaces" to use flat, neutron, or noop, in that order, are generally applicable. Signed-off-by: Julia Kreger <[email protected]>
b973a58
to
49804b6
Compare
I just rebased against main, on speculation that the kuttl job isn't doing that on PRs 🤷 |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1f309f32bc3f477ba45150179ca09a3f ✔️ noop SUCCESS in 0s |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliakreger, steveb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e90e56e03dc8461f8757ec2ba7d559fa ✔️ noop SUCCESS in 0s |
recheck |
openstack-k8s-operators/ci-framework#2536 merged, and as such a recheck has been issued. This should now pass now that the typo has been fixed in the test name. |
/retest |
5b4dcbe
into
openstack-k8s-operators:main
The default interface parameter inadvertently set the default for all newly created nodes, unless they otherwise specify a network interface, to be "noop", which is only usable for standalone users.
Integrated users want flat, or neutron. Given historical usage pattern, the existing defaults set via "enabled_network_interfaces" to use flat, neutron, or noop, in that order, are generally applicable.
Jira: OSPRH-10697