Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default network interface #492

Conversation

juliakreger
Copy link
Contributor

@juliakreger juliakreger commented Nov 1, 2024

The default interface parameter inadvertently set the default for all newly created nodes, unless they otherwise specify a network interface, to be "noop", which is only usable for standalone users.

Integrated users want flat, or neutron. Given historical usage pattern, the existing defaults set via "enabled_network_interfaces" to use flat, neutron, or noop, in that order, are generally applicable.

Jira: OSPRH-10697

@juliakreger juliakreger requested a review from steveb November 1, 2024 20:38
@openshift-ci openshift-ci bot requested a review from dprince November 1, 2024 20:38
@openshift-ci openshift-ci bot added the approved label Nov 1, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/65d4e3d628e74e4e85f8ea3f37b2c225

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 15s
podified-multinode-ironic-deployment FAILURE in 1h 01m 49s

Copy link
Collaborator

@steveb steveb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This will likely need #493 for kuttl to pass

@steveb
Copy link
Collaborator

steveb commented Nov 5, 2024

/retest

1 similar comment
@juliakreger
Copy link
Contributor Author

/retest

The default interface parameter inadvertently set the default for
all newly created nodes, unless they otherwise specify a network
interface, to be "noop", which is only usable for standalone users.

Integrated users want flat, or neutron. Given historical usage
pattern, the existing defaults set via "enabled_network_interfaces"
to use flat, neutron, or noop, in that order, are generally applicable.

Signed-off-by: Julia Kreger <[email protected]>
@steveb steveb force-pushed the fix-default-network-interface branch from b973a58 to 49804b6 Compare November 6, 2024 03:43
@openshift-ci openshift-ci bot removed the lgtm label Nov 6, 2024
@steveb
Copy link
Collaborator

steveb commented Nov 6, 2024

I just rebased against main, on speculation that the kuttl job isn't doing that on PRs 🤷

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1f309f32bc3f477ba45150179ca09a3f

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 00m 55s
podified-multinode-ironic-deployment FAILURE in 43m 28s

@juliakreger
Copy link
Contributor Author

/retest

Copy link
Collaborator

@steveb steveb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliakreger, steveb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliakreger
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e90e56e03dc8461f8757ec2ba7d559fa

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 39s
podified-multinode-ironic-deployment FAILURE in 43m 49s

@juliakreger
Copy link
Contributor Author

recheck

@juliakreger
Copy link
Contributor Author

openstack-k8s-operators/ci-framework#2536 merged, and as such a recheck has been issued. This should now pass now that the typo has been fixed in the test name.

@juliakreger
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 5b4dcbe into openstack-k8s-operators:main Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants