Add webhook to validate service override endpoint type #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold until after freeze |
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
May 14, 2024
Adds calling service operator validations from within the openstack-operator for: - barbican - neutron - glance - cinder - heat - manila - swift - octavia - designate Depends-On: openstack-k8s-operators/barbican-operator#115 Depends-On: openstack-k8s-operators/neutron-operator#347 Depends-On: openstack-k8s-operators/glance-operator#529 Depends-On: openstack-k8s-operators/cinder-operator#384 Depends-On: openstack-k8s-operators/heat-operator#361 Depends-On: openstack-k8s-operators/manila-operator#273 Depends-On: openstack-k8s-operators/swift-operator#218 Depends-On: openstack-k8s-operators/octavia-operator#301 Depends-On: openstack-k8s-operators/designate-operator#166
abays
reviewed
May 23, 2024
Can also be called from the openstack-operator webhook on the HeatSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ec8b6fd
into
openstack-k8s-operators:main
6 checks passed
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
May 23, 2024
Adds calling service operator validations from within the openstack-operator for: - barbican - neutron - glance - cinder - heat - manila - swift - octavia - designate Depends-On: openstack-k8s-operators/barbican-operator#115 Depends-On: openstack-k8s-operators/neutron-operator#347 Depends-On: openstack-k8s-operators/glance-operator#529 Depends-On: openstack-k8s-operators/cinder-operator#384 Depends-On: openstack-k8s-operators/heat-operator#361 Depends-On: openstack-k8s-operators/manila-operator#273 Depends-On: openstack-k8s-operators/swift-operator#218 Depends-On: openstack-k8s-operators/octavia-operator#301 Depends-On: openstack-k8s-operators/designate-operator#166
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
May 23, 2024
Adds calling service operator validations from within the openstack-operator for: - barbican - neutron - glance - cinder - heat - manila - swift - octavia - designate Depends-On: openstack-k8s-operators/barbican-operator#115 Depends-On: openstack-k8s-operators/neutron-operator#347 Depends-On: openstack-k8s-operators/glance-operator#529 Depends-On: openstack-k8s-operators/cinder-operator#384 Depends-On: openstack-k8s-operators/heat-operator#361 Depends-On: openstack-k8s-operators/manila-operator#273 Depends-On: openstack-k8s-operators/swift-operator#218 Depends-On: openstack-k8s-operators/octavia-operator#301 Depends-On: openstack-k8s-operators/designate-operator#166
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
May 24, 2024
Adds calling service operator validations from within the openstack-operator for: - keystone - barbican - neutron - glance - cinder - heat - manila - swift - octavia - designate Depends-On: openstack-k8s-operators/keystone-operator#414 Depends-On: openstack-k8s-operators/barbican-operator#115 Depends-On: openstack-k8s-operators/neutron-operator#347 Depends-On: openstack-k8s-operators/glance-operator#529 Depends-On: openstack-k8s-operators/cinder-operator#384 Depends-On: openstack-k8s-operators/heat-operator#361 Depends-On: openstack-k8s-operators/manila-operator#273 Depends-On: openstack-k8s-operators/swift-operator#218 Depends-On: openstack-k8s-operators/octavia-operator#301 Depends-On: openstack-k8s-operators/designate-operator#166
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 3, 2024
Adds calling service operator validations from within the openstack-operator for: - keystone - barbican - neutron - glance - cinder - heat - manila - swift - octavia - designate Depends-On: openstack-k8s-operators/keystone-operator#414 Depends-On: openstack-k8s-operators/barbican-operator#115 Depends-On: openstack-k8s-operators/neutron-operator#347 Depends-On: openstack-k8s-operators/glance-operator#529 Depends-On: openstack-k8s-operators/cinder-operator#384 Depends-On: openstack-k8s-operators/heat-operator#361 Depends-On: openstack-k8s-operators/manila-operator#273 Depends-On: openstack-k8s-operators/swift-operator#218 Depends-On: openstack-k8s-operators/octavia-operator#301 Depends-On: openstack-k8s-operators/designate-operator#166
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Jun 3, 2024
Adds calling service operator validations from within the openstack-operator for: - keystone - barbican - neutron - glance - cinder - heat - manila - swift - octavia - designate Depends-On: openstack-k8s-operators/keystone-operator#414 Depends-On: openstack-k8s-operators/barbican-operator#115 Depends-On: openstack-k8s-operators/neutron-operator#347 Depends-On: openstack-k8s-operators/glance-operator#529 Depends-On: openstack-k8s-operators/cinder-operator#384 Depends-On: openstack-k8s-operators/heat-operator#361 Depends-On: openstack-k8s-operators/manila-operator#273 Depends-On: openstack-k8s-operators/swift-operator#218 Depends-On: openstack-k8s-operators/octavia-operator#301 Depends-On: openstack-k8s-operators/designate-operator#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can also be called from the openstack-operator webhook on the HeatSpecCore, like for other operators in [1].
Depends-On: openstack-k8s-operators/lib-common#505
[1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181