-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service Endpoint Validate() method #505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/hold until after beta freeze |
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
May 7, 2024
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
May 7, 2024
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
May 7, 2024
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
May 7, 2024
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
May 7, 2024
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
May 7, 2024
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
May 7, 2024
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
May 7, 2024
stuggi
added a commit
to stuggi/ironic-operator
that referenced
this pull request
May 7, 2024
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
May 8, 2024
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
May 8, 2024
stuggi
added a commit
to stuggi/ironic-operator
that referenced
this pull request
May 8, 2024
gibizer
reviewed
May 8, 2024
This method can e.g. be used in webhooks to validate if the configuration in the CR is correct.
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
May 8, 2024
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
May 8, 2024
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
May 8, 2024
stuggi
added a commit
to stuggi/ironic-operator
that referenced
this pull request
May 8, 2024
stuggi
added a commit
to stuggi/barbican-operator
that referenced
this pull request
May 8, 2024
stuggi
added a commit
to stuggi/neutron-operator
that referenced
this pull request
May 8, 2024
stuggi
added a commit
to stuggi/designate-operator
that referenced
this pull request
May 8, 2024
Can also be called from the openstack-operator webhook on the DesignateSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
May 13, 2024
abays
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
stuggi
added a commit
to stuggi/placement-operator
that referenced
this pull request
May 22, 2024
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
May 22, 2024
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
May 22, 2024
stuggi
added a commit
to stuggi/ironic-operator
that referenced
this pull request
May 22, 2024
stuggi
added a commit
to stuggi/barbican-operator
that referenced
this pull request
May 22, 2024
stuggi
added a commit
to stuggi/neutron-operator
that referenced
this pull request
May 22, 2024
stuggi
added a commit
to stuggi/glance-operator
that referenced
this pull request
May 22, 2024
Updates webhook to be able to be call from the openstack-operator webhook on the GlanceSpecCore, like for other operators in [1]. Also adds check for valid service override endpoint type on create and update. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/cinder-operator
that referenced
this pull request
May 22, 2024
Can also be called from the openstack-operator webhook on the CinderSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/heat-operator
that referenced
this pull request
May 22, 2024
Can also be called from the openstack-operator webhook on the HeatSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/manila-operator
that referenced
this pull request
May 22, 2024
Can also be called from the openstack-operator webhook on the HeatSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/swift-operator
that referenced
this pull request
May 22, 2024
Can also be called from the openstack-operator webhook on the SwiftSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/designate-operator
that referenced
this pull request
May 22, 2024
Can also be called from the openstack-operator webhook on the DesignateSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/octavia-operator
that referenced
this pull request
May 22, 2024
Can also be called from the openstack-operator webhook on the OctaviaSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
May 22, 2024
stuggi
added a commit
to stuggi/swift-operator
that referenced
this pull request
May 22, 2024
Can also be called from the openstack-operator webhook on the SwiftSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/placement-operator
that referenced
this pull request
May 22, 2024
stuggi
added a commit
to stuggi/manila-operator
that referenced
this pull request
May 23, 2024
Can also be called from the openstack-operator webhook on the HeatSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/heat-operator
that referenced
this pull request
May 23, 2024
Can also be called from the openstack-operator webhook on the HeatSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/swift-operator
that referenced
this pull request
May 23, 2024
Can also be called from the openstack-operator webhook on the SwiftSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/cinder-operator
that referenced
this pull request
May 23, 2024
Can also be called from the openstack-operator webhook on the CinderSpecCore, like for other operators in [1]. Depends-On: openstack-k8s-operators/lib-common#505 [1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
Jun 3, 2024
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/nova-operator
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method can e.g. be used in webhooks to validate if the configuration in the CR is correct.