Rework glance config process #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmount
requested review from
konan-abhi
and removed request for
viroel and
Sandeepyadav93
|
/retest |
fmount
commented
Aug 20, 2023
fmount
commented
Aug 21, 2023
konan-abhi
reviewed
Aug 21, 2023
This patch represents an implementation of the proposal [1] and aligns
the glance-operator with the work already done in Cinder and the other
storage operators. There are a few relevant changes in the bootstrap
process of Glance, in particular:
- It stops using an init container to generate the snippet files that
configure each glanceAPI service. The logic that was previously
implemented in the Init Container has been moved to the Controllers,
where config files are generated and stored in k8s Secrets. Init
Containers are fully removed from the bootstrap process;
- It uses Kolla to copy the generated content to the target directory
/etc/glance/glance.conf.d, which is used by each API service to run;
- The relevant content, including scripts, previously stored in a
ConfigMap, are now stored in a corresponding k8s Secret, which is
mounted to the GlanceAPI deployment Pods (hence no additional calls
to GetVolume/GetVolumeMounts are required);
- A total of 4 config snippet files are generated:
- 00-config.conf contains global settings that are common to every
GlanceAPI Pod, including ones that are derived from deployment
secrets (e.g. database password, etc.)
- 01-config.conf contains the global customServiceConfig settings
that apply to every GlanceAPI service.
- 02-config.conf contains the customServiceConfig settings that
are specific to each service.
- 03-config.conf contains secrets specified by each service's
customServiceConfigSecrets.
- glance-image-import.conf has been removed, and the default config has
been added to 00-config.conf, which is the common file generated by
the umbrella Glance controller;
- logging.conf has been removed as it's no longer required in the switch
to a side container approach for logging purposes;
- functional tests are aligned to the use of k8s Secrets instead of the
old pattern based on ConfigMaps;
- kuttl tests are updated and the 'initContainer' has been removed.
- dbsync now mounts only the required files (a minimal 00-config.conf)
and a db-sync-config.json containing the command run through kolla.
[1] openstack-k8s-operators/dev-docs#31
Signed-off-by: Francesco Pantano <[email protected]>
konan-abhi
approved these changes
Aug 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, konan-abhi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch represents an implementation of the proposal [1] and aligns the
glance-operatorwith the work already done inCinderand the other operators.There are a few relevant changes in the bootstrap process of
Glance, in particular:InitContainerto generate the snippet files that configure eachGlanceAPIservice. The logic that was previously implemented in theInitContainerhas been moved to theControllers, where config files are generated and stored in k8sSecrets.InitContainersare fully removed from the bootstrap process;Kollato copy the generated content to the target directory/etc/glance/glance.conf.d, which is used by eachAPIservice to run;ConfigMap, are now stored in a corresponding k8sSecret, which is mounted to theGlanceAPIdeploymentPods(hence no additional calls toGetVolume/GetVolumeMountsare required);00-config.confcontains global settings that are common to everyGlanceAPIPod, including ones that are derived from deployment secrets (e.g. database password, etc.)01-config.confcontains the globalcustomServiceConfigsettings that apply to every GlanceAPI service.02-config.confcontains thecustomServiceConfigsettings that are specific to each service.03-config.confcontains secrets specified by each service'scustomServiceConfigSecrets.glance-image-import.confhas been removed, and the default config has been added to00-config.conf, which is the common file generated by the umbrellaGlancecontroller;logging.confhas been removed as it's no longer required in the switch to a side container approach for logging purposes;Secretsinstead of the old pattern based onConfigMaps;kuttltests are updated and theinitContainerhas been removed.DBsyncnow mounts only the required files (a minimal00-config.conf) and adb-sync-config.jsoncontaining the command run throughkolla.[1] openstack-k8s-operators/dev-docs#31