WIP - Remove initcontainer and process secrets passed as input #221
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fmount
force-pushed
the
process_secret_conf
branch
from
8ebea46 to
67525ef
Compare
fmount
changed the title
There are many goals achieved by this patch: 1. we're able to remove (entirely) the initcontainer and the related scripts that are no longer required to start the service 2. kolla is still used to copy additional files and templates from src to dst, as they rendered accordingly (secrets for sensitive information and configmap for regular overrides) and mounted to the destination directory 3. Controllers are able to parse many secrets referenced by the CustomServiceConfigSecrets parameter and merge them into a single secret (04-secret.conf) which is passed to the deployment and mounted to the target pod Still WIP but good progress so far on the main goal. Signed-off-by: Francesco Pantano <[email protected]>
fmount
force-pushed
the
process_secret_conf
branch
from
67525ef to
9f08e86
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@fmount: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There are many goals achieved by this patch:
we're able to remove (entirely) the initcontainer and the related scripts that are no longer required to start the service
kolla is still used to copy additional files and templates from src to dst, as they rendered accordingly (secrets for sensitive information and configmap for regular overrides) and mounted to the destination directory
Controllers are able to parse many secrets referenced by the CustomServiceConfigSecrets parameter and merge them into a single secret (04-secret.conf) which is passed to the deployment and mounted to the target pod
Still WIP but good progress so far on the main goal.