Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ovn-controller and neutron-metadata-agent roles #382

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Sep 29, 2023

This allows for network node deployment, where most of the time the metadata agent is not needed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

Hi @luis5tb. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb luis5tb changed the title Split ovn-controller and neutron-metadata-agent roles [WIP] Split ovn-controller and neutron-metadata-agent roles Sep 29, 2023
luis5tb added a commit to luis5tb/dataplane-operator that referenced this pull request Sep 29, 2023
@booxter
Copy link
Contributor

booxter commented Sep 29, 2023

The molecule job for the new role should be added.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/52de5608ec54414b8ae1ea31486fe83a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 47s
podified-multinode-edpm-deployment-crc FAILURE in 1h 23m 39s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 15s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 41s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 29s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 18s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 46s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e4cd6c583ba247d49bad2645604343ee

openstack-k8s-operators-content-provider RETRY_LIMIT in 8s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 43s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 56s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 21s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 50s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 00s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ca4c1dfaff5c449ca779c33ca5912de8

✔️ openstack-k8s-operators-content-provider SUCCESS in 31m 11s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 18m 05s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 40s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 12s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 57s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 02s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 56s

Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some comments.

roles/edpm_neutron_metadata/defaults/main.yml Outdated Show resolved Hide resolved
roles/edpm_neutron_metadata/meta/argument_specs.yml Outdated Show resolved Hide resolved
roles/edpm_neutron_metadata/tasks/main.yml Outdated Show resolved Hide resolved
roles/edpm_neutron_metadata/tasks/main.yml Outdated Show resolved Hide resolved
roles/edpm_neutron_metadata/tasks/run.yml Outdated Show resolved Hide resolved
roles/edpm_neutron_metadata/templates/rootwrap.conf.j2 Outdated Show resolved Hide resolved
roles/edpm_ovn/tasks/install.yml Outdated Show resolved Hide resolved
@luis5tb luis5tb force-pushed the metadata branch 3 times, most recently from 1814fa6 to f25b8fa Compare October 3, 2023 07:54
@luis5tb
Copy link
Contributor Author

luis5tb commented Oct 3, 2023

/retest edpm_neutron_metadata

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

@luis5tb: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest edpm_neutron_metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor Author

luis5tb commented Oct 3, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

@luis5tb: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb luis5tb force-pushed the metadata branch 2 times, most recently from 7aeffff to 6035c20 Compare October 3, 2023 10:33
@luis5tb luis5tb changed the title [WIP] Split ovn-controller and neutron-metadata-agent roles Split ovn-controller and neutron-metadata-agent roles Oct 3, 2023
@booxter
Copy link
Contributor

booxter commented Oct 3, 2023

/ok-to-test

luis5tb added a commit to luis5tb/dataplane-operator that referenced this pull request Oct 9, 2023
This depends on the edpm-ansible PR that split the roles
Depends-On: openstack-k8s-operators/edpm-ansible#382
luis5tb added a commit to luis5tb/dataplane-operator that referenced this pull request Oct 9, 2023
This depends on the edpm-ansible PR that split the roles
Depends-On: openstack-k8s-operators/edpm-ansible#382
@openshift-ci openshift-ci bot removed the lgtm label Oct 9, 2023
@luis5tb
Copy link
Contributor Author

luis5tb commented Oct 9, 2023

/test pre-commit-test

@luis5tb luis5tb force-pushed the metadata branch 2 times, most recently from 63654c4 to c1f342b Compare October 9, 2023 11:41
luis5tb added a commit to luis5tb/dataplane-operator that referenced this pull request Oct 9, 2023
This depends on the edpm-ansible PR that split the roles
Depends-On: openstack-k8s-operators/edpm-ansible#382
playbooks/neutron_metadata.yaml Outdated Show resolved Hide resolved
playbooks/neutron_metadata.yaml Outdated Show resolved Hide resolved
roles/edpm_neutron_metadata/OWNERS Show resolved Hide resolved
- network-approvers

reviewers:
- network-approvers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here too

This allows for network node deployment, where most of the
time the metadata agent is not needed
@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ac582b85a24746b4953a3a45498f378d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 45s
podified-multinode-edpm-deployment-crc FAILURE in 1h 30m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 54s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 8m 01s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 6m 57s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 06s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 32s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 00s

@slagle
Copy link
Contributor

slagle commented Oct 10, 2023

Copy link
Contributor

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f3df0f785ec2448ca4c5acec9ec378f5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 25m 57s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 4m 01s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 57s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 15s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 44s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 11s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 06s

@booxter
Copy link
Contributor

booxter commented Oct 10, 2023

/lgtm

@booxter
Copy link
Contributor

booxter commented Oct 10, 2023

recheck

Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin, luis5tb, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 718ca9c into openstack-k8s-operators:main Oct 11, 2023
luis5tb added a commit to luis5tb/dataplane-operator that referenced this pull request Oct 11, 2023
This depends on the edpm-ansible PR that split the roles
Depends-On: openstack-k8s-operators/edpm-ansible#382
luis5tb added a commit to luis5tb/dataplane-operator that referenced this pull request Oct 11, 2023
This depends on the edpm-ansible PR that split the roles
Depends-On: openstack-k8s-operators/edpm-ansible#382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants