-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split ovn-controller and neutron-metadata-agent roles #382
Conversation
Hi @luis5tb. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This depends on the edpm-ansible PR: openstack-k8s-operators/edpm-ansible#382
The molecule job for the new role should be added. |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/52de5608ec54414b8ae1ea31486fe83a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 47s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e4cd6c583ba247d49bad2645604343ee ❌ openstack-k8s-operators-content-provider RETRY_LIMIT in 8s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ca4c1dfaff5c449ca779c33ca5912de8 ✔️ openstack-k8s-operators-content-provider SUCCESS in 31m 11s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Some comments.
1814fa6
to
f25b8fa
Compare
/retest edpm_neutron_metadata |
@luis5tb: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@luis5tb: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7aeffff
to
6035c20
Compare
/ok-to-test |
This depends on the edpm-ansible PR that split the roles Depends-On: openstack-k8s-operators/edpm-ansible#382
This depends on the edpm-ansible PR that split the roles Depends-On: openstack-k8s-operators/edpm-ansible#382
/test pre-commit-test |
63654c4
to
c1f342b
Compare
This depends on the edpm-ansible PR that split the roles Depends-On: openstack-k8s-operators/edpm-ansible#382
- network-approvers | ||
|
||
reviewers: | ||
- network-approvers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here too
This allows for network node deployment, where most of the time the metadata agent is not needed
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ac582b85a24746b4953a3a45498f378d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 45s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f3df0f785ec2448ca4c5acec9ec378f5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 43s |
/lgtm |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karelyatin, luis5tb, slawqo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This depends on the edpm-ansible PR that split the roles Depends-On: openstack-k8s-operators/edpm-ansible#382
This depends on the edpm-ansible PR that split the roles Depends-On: openstack-k8s-operators/edpm-ansible#382
This allows for network node deployment, where most of the time the metadata agent is not needed