Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Add support for ovn-controller and neutron-metadata-agent split #445

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add support for ovn-controller and neutron-metadata-agent split #445

merged 2 commits into from
Oct 12, 2023

Conversation

luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Sep 29, 2023 •
edited by rebtoor
Loading

This depends on the edpm-ansible PR:
Depends-On: openstack-k8s-operators/edpm-ansible#382

@luis5tb luis5tb changed the title Add support for ovn-controller and neutron-metadata-agent split [WIP] Add support for ovn-controller and neutron-metadata-agent split Sep 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

Hi @luis5tb. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7328d5eeef94431e9ae337f4cea58c2c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 06s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 22m 16s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 18m 02s
✔️ dataplane-operator-docs-preview SUCCESS in 1m 54s

@luis5tb luis5tb changed the title [WIP] Add support for ovn-controller and neutron-metadata-agent split Add support for ovn-controller and neutron-metadata-agent split Oct 3, 2023
@booxter
Copy link
Contributor

booxter commented Oct 3, 2023

/ok-to-test

@booxter
Copy link
Contributor

booxter commented Oct 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 3, 2023
@openshift-ci openshift-ci bot removed the lgtm label Oct 5, 2023
@rebtoor rebtoor mentioned this pull request Oct 5, 2023
Merged
@rebtoor
Copy link
Contributor

rebtoor commented Oct 5, 2023

IMHO the kuttl test is failing because the ansibleee-runner image that is using is wrong.

From logs:

image: quay.io/openstack-k8s-operators/openstack-ansibleee-runner@sha256:64eaa1d99e0103cb4536fa9f396d41c467168cab3fe3821f8135e9a9638d7295

which is: https://quay.io/repository/openstack-k8s-operators/openstack-ansibleee-runner/manifest/sha256:64eaa1d99e0103cb4536fa9f396d41c467168cab3fe3821f8135e9a9638d7295

pushed on quay by this pr: openstack-k8s-operators/edpm-ansible#375

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/af9d1b2a210d4852966deaaacabb60af

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 47s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 20m 05s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 17m 44s
✔️ dataplane-operator-docs-preview SUCCESS in 1m 52s

@rebtoor
Copy link
Contributor

rebtoor commented Oct 5, 2023 •
edited
Loading

recheck

probably the depends-on has been added after the jobs were already started because they were using the same old ansibleee runner as kuttl tests: https://review.rdoproject.org/zuul/build/0e7cb4a498394f90b648a9e7531b7d60/log/controller/ci-framework-data/logs/crc/crs/openstackansibleees.yaml

edit: Depends-on was missing 😅

karelyatin
karelyatin reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 5, 2023
@rebtoor
Copy link
Contributor

rebtoor commented Oct 5, 2023

/test dataplane-operator-build-deploy-kuttl

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/19576cbe3321494b955354e67b432c83

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 52s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 21m 38s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 14m 39s
✔️ dataplane-operator-docs-preview SUCCESS in 1m 50s

@rebtoor
Copy link
Contributor

rebtoor commented Oct 5, 2023

recheck

(i added the Depends-On after the job started... as for my edit in the first comment)

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8a35f341ea7149cebc6c2448ae59d1e0

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 36m 23s
❌ podified-multinode-edpm-deployment-crc TIMED_OUT in 3h 08m 47s
❌ cifmw-crc-podified-edpm-baremetal TIMED_OUT in 3h 03m 07s
✔️ dataplane-operator-docs-preview SUCCESS in 1m 58s

@rebtoor
Copy link
Contributor

rebtoor commented Oct 6, 2023

recheck

@karelyatin
Copy link
Contributor

@rebtoor do prow kuttl jobs now supports cross repo changes with Depends-On? in past that was a limitation.

@luis5tb
Copy link
Contributor Author

luis5tb commented Oct 11, 2023 •
edited
Loading

recheck

1 similar comment
@karelyatin
Copy link
Contributor

recheck

@gibizer gibizer mentioned this pull request Oct 11, 2023
Merged
@gibizer
Copy link
Contributor

gibizer commented Oct 11, 2023

We need this to get our tempest job back to green state openstack-k8s-operators/nova-operator#556 (comment) But hey, we have a tempest job that verifies that metadata works end to end. :)

@booxter
Copy link
Contributor

booxter commented Oct 11, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luis5tb, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rebtoor rebtoor removed the lgtm label Oct 11, 2023
@rebtoor rebtoor self-requested a review October 11, 2023 15:12
@booxter
Copy link
Contributor

booxter commented Oct 11, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 11, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fabde0f41f6f40058c674948bdf60f0e

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 58s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 17m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 03m 48s
✔️ dataplane-operator-docs-preview SUCCESS in 1m 59s

@luis5tb
Add support for ovn-controller and neutron-metadata-agent split
5c98ac1 
This depends on the edpm-ansible PR that split the roles
Depends-On: openstack-k8s-operators/edpm-ansible#382
@luis5tb
Remove image check for kuttl test
1249f39 
This is making the test to fail everytime a new image is used
@openshift-ci openshift-ci bot removed the lgtm label Oct 11, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/debf264fe5fa4c76baa3332b7f786e5b

❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 200-0006469555 failed in 0s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ dataplane-operator-docs-preview SUCCESS in 1m 52s

@karelyatin
Copy link
Contributor

/test dataplane-operator-build-deploy-kuttl
must-gather failed

@karelyatin
Copy link
Contributor

recheck NODE_FAILURE

@karelyatin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 12, 2023
@openshift-ci openshift-ci bot merged commit 9e18aa4 into openstack-k8s-operators:main Oct 12, 2023
2 checks passed
@karelyatin karelyatin mentioned this pull request Oct 12, 2023
Merged
1 task
booxter added a commit to booxter/architecture that referenced this pull request Oct 12, 2023
@booxter
stage6: deploy metadata agent
4fafe73 
Since [1], ovn service no longer deploys metadata agent. We should
select it explicitly.

[1] openstack-k8s-operators/dataplane-operator#445,
booxter added a commit to booxter/architecture that referenced this pull request Oct 12, 2023
@booxter
stage6: deploy metadata agent
66d0a37 
Since [1], ovn service no longer deploys metadata agent. We should
select it explicitly.

[1] openstack-k8s-operators/dataplane-operator#445
@booxter booxter mentioned this pull request Oct 12, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karelyatin karelyatin karelyatin left review comments

@slawqo slawqo slawqo left review comments

@slagle slagle slagle left review comments

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

@rebtoor rebtoor Awaiting requested review from rebtoor

Assignees

@booxter booxter

@rebtoor rebtoor

@karelyatin karelyatin

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@luis5tb @booxter @rebtoor @karelyatin @gibizer @slagle @slawqo