Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing edpm_nova_compute and edpm_nova_libvirt roles #349

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Removing edpm_nova_compute and edpm_nova_libvirt roles #349

merged 1 commit into from
Sep 28, 2023

Conversation

jpodivin
Copy link
Contributor

Since the roles are no longer necessary, as their tasks are handled directly by nova operator, we can safely remove them.

@openshift-ci openshift-ci bot requested review from fultonj and viroel September 19, 2023 13:59
@fultonj fultonj requested a review from SeanMooney September 19, 2023 14:04
fultonj
fultonj reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

@booxter
Copy link
Contributor

booxter commented Sep 19, 2023

/lgtm

git actions will need to be cleaned up

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2023
@booxter booxter removed the lgtm label Sep 19, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/358139995b09473e8f5965b092fcc62e

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 14m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 57m 58s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 3h 01m 10s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 04s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 49s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 25s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 21s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 30s

@jpodivin jpodivin force-pushed the removing-legacy-nova branch from a90b55d to 1790146 Compare September 20, 2023 08:26
@jpodivin
Copy link
Contributor Author

/lgtm

git actions will need to be cleaned up

I totally forgot about that :)

@jpodivin jpodivin requested a review from fultonj September 20, 2023 08:36
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0b4062938290401b97da498af6318396

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 15m 39s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 55m 24s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 22m 04s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 14s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 17s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 58s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 31s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 40s

@jpodivin
Copy link
Contributor Author

recheck

@SeanMooney
Copy link
Contributor

it would be preferable to wait for #334 to merge first to avoid conflicts but in general yes
i abandoned #94 with the intent to repopose a new version this week anyway so I'm fine with using this pr to do that.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ef259b1f9e1c456ab3c4ab7ce4829142

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 52s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 51m 37s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 15m 20s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 10s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 6m 02s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 59s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 55s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 53s

@jpodivin
Copy link
Contributor Author

recheck

slagle
slagle reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably ought to wait on #160 and #334. After those, it lgtm.

@jpodivin jpodivin force-pushed the removing-legacy-nova branch from 1790146 to 02b8f37 Compare September 21, 2023 07:34
@jpodivin
Copy link
Contributor Author

This probably ought to wait on #160 and #334. After those, it lgtm.

#160 Seems to be on hold for now. I would say that faster resolution may be to keep epm_nova_compute unmodified and merge changes after this PR.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7e86b6e6b90c449980bee30eb8d400e8

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 08m 22s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 55m 32s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 45m 28s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 8m 02s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 6m 26s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 13m 28s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 17s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 38s

@jpodivin jpodivin force-pushed the removing-legacy-nova branch from 02b8f37 to d0122fd Compare September 21, 2023 11:14
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/698090489997492799024a0e56249b77

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 04m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 51m 38s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 43m 12s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 05s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 02s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 32s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 50s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 10s

@jpodivin
Copy link
Contributor Author

recheck

@slagle
Copy link
Contributor

slagle commented Sep 26, 2023

This probably ought to wait on #160 and #334. After those, it lgtm.

#160 Seems to be on hold for now. I would say that faster resolution may be to keep epm_nova_compute unmodified and merge changes after this PR.

These are both merged now, but the resulting conflicts need to be fixed.

@jpodivin
Removing edpm_nova_compute and edpm_nova_libvirt roles
7f98c79 
Since the roles are no longer necessary, as their tasks are handled directly
by nova operator, we can safely remove them.

Signed-off-by: Jiri Podivin <[email protected]>
@jpodivin jpodivin force-pushed the removing-legacy-nova branch from d0122fd to 7f98c79 Compare September 27, 2023 07:28
@openshift-ci openshift-ci bot added the lgtm label Sep 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a5931c1 into openstack-k8s-operators:main Sep 28, 2023
@jpodivin jpodivin deleted the removing-legacy-nova branch October 2, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slagle slagle slagle left review comments

@rebtoor rebtoor rebtoor approved these changes

@viroel viroel Awaiting requested review from viroel

@SeanMooney SeanMooney Awaiting requested review from SeanMooney

@fultonj fultonj Awaiting requested review from fultonj

Assignees

@booxter booxter

@rebtoor rebtoor

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jpodivin @booxter @SeanMooney @slagle @rebtoor @fultonj @openshift-merge-robot