-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract host user,group and dir creation to edpm_users role #334
extract host user,group and dir creation to edpm_users role #334
Conversation
bc54108
to
a7cea36
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/d661a2a7690f4828aa0fbd48bfa6530c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 51s |
a7cea36
to
7908527
Compare
fixed doc text otherwise this is the same |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ecc983d4e9ac49c2be8b7f15484010f3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 21m 18s |
roles/edpm_users/.yamllint
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't like the idea to have a yamllint file specific for a role. I'd change the file on root folder if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is form the default templeate we have for creating new roles ill just delete this.
This change factors out the code to create users/groups that must map to the same uid/gid within or outside of a container. This is required to supprot ovs-dpdk where the hugepage and vhost user socket permission must align to enabel ovs-dpdk running on the host to comunciate with qemu running in a container. Thsi work enabled the future removal of the edpm_nova_compute and edpm_nova_libvirt roles.
7908527
to
37dff53
Compare
/retest |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a29f650bc3a94a1ab3dfae4f643b75db ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 05m 31s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1e88b1187fc947e39da4fa3e71b01d45 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 19m 24s |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bogdando, rebtoor, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/d46521b4695d4726b11fdb5e94e41ab9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 28s |
recheck |
This change factors out the code to create users/groups that must
map to the same uid/gid within or outside of a container.
This is required to supprot ovs-dpdk where the hugepage and
vhost user socket permission must align to enabel ovs-dpdk
running on the host to comunciate with qemu running in a container.
Thsi work enabled the future removal of the edpm_nova_compute
and edpm_nova_libvirt roles.