Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract host user,group and dir creation to edpm_users role #334

Conversation

SeanMooney
Copy link
Contributor

This change factors out the code to create users/groups that must
map to the same uid/gid within or outside of a container.

This is required to supprot ovs-dpdk where the hugepage and
vhost user socket permission must align to enabel ovs-dpdk
running on the host to comunciate with qemu running in a container.

Thsi work enabled the future removal of the edpm_nova_compute
and edpm_nova_libvirt roles.

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d661a2a7690f4828aa0fbd48bfa6530c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 51s
podified-multinode-edpm-deployment-crc FAILURE in 1h 22m 20s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 04m 14s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 54s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 6m 25s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 28s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 7m 21s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 40s

@SeanMooney
Copy link
Contributor Author

fixed doc text otherwise this is the same

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ecc983d4e9ac49c2be8b7f15484010f3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 21m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 49m 49s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 07m 13s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 59s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 13s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 08s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 13s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 16s

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't like the idea to have a yamllint file specific for a role. I'd change the file on root folder if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is form the default templeate we have for creating new roles ill just delete this.

roles/edpm_users/molecule/default/converge.yml Outdated Show resolved Hide resolved
roles/edpm_bootstrap/tasks/bootstrap.yml Outdated Show resolved Hide resolved
This change factors out the code to create users/groups that must
map to the same uid/gid within or outside of a container.

This is required to supprot ovs-dpdk where the hugepage and
vhost user socket permission must align to enabel ovs-dpdk
running on the host to comunciate with qemu running in a container.

Thsi work enabled the future removal of the edpm_nova_compute
and edpm_nova_libvirt roles.
@rebtoor
Copy link
Contributor

rebtoor commented Sep 18, 2023

/retest

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a29f650bc3a94a1ab3dfae4f643b75db

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 05m 31s
podified-multinode-edpm-deployment-crc POST_FAILURE in 47m 02s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 50m 17s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 32s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 52s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 52s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 47s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 49s

@rebtoor
Copy link
Contributor

rebtoor commented Sep 18, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1e88b1187fc947e39da4fa3e71b01d45

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 19m 24s
podified-multinode-edpm-deployment-crc POST_FAILURE in 47m 03s
cifmw-crc-podified-edpm-baremetal FAILURE in 52m 13s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 38s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 59s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 36s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 39s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 51s

@bogdando bogdando self-requested a review September 19, 2023 11:27
@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bogdando, rebtoor, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fao89
Copy link
Contributor

fao89 commented Sep 20, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d46521b4695d4726b11fdb5e94e41ab9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 28s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 53m 55s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 11m 31s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 22s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 54s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 13s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 42s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 25s

@jpodivin
Copy link
Contributor

recheck

@openshift-merge-robot openshift-merge-robot merged commit 1d4a09b into openstack-k8s-operators:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants