Remove remaining container images from test roles #175
Conversation
| @@ -121,7 +121,6 @@ | |||
| enabled: true | |||
| template: | |||
| ovnNorthd: | |||
| containerImage: {{ container_registry|default("quay.io") }}/{{ container_namespace|default("podified-antelope-centos9") }}/openstack-ovn-northd:{{ container_tag | default("current-podified") }} | |||
There was a problem hiding this comment.
I'm not sure if we can remove the ovnNorthd image, I don't see it in the ovn section of the container_overrides templates
There was a problem hiding this comment.
Good catch i'll add it.
There was a problem hiding this comment.
Done. I also fixed indentation where i noticed it being off in that file.
There was a problem hiding this comment.
right - I left these where they were and meant to cycle back and check if we really wanted/needed them hard-coded here.
thanks @jistr adding to the overrides should keep the period jobs doing the right thing, and otherwise it will default to current-podified
The two containerImage parameters removed here are the only ones remaining in the test roles. For normal usage, this is defaulted in the operators and we shouldn't need to set it. For periodic CI, these values are overriden with particular non-latest container URLs via the kustomization mechanism. So i think these shouldn't be necessary and can be removed too. Related: openstack-k8s-operators#110 openstack-k8s-operators#165
jistr
force-pushed
the
f/remove-image-urls-from-test-roles
branch
from
3d755be to
b018949
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/280d598007af416086fefaea55bfcd22 ❌ data-plane-adoption-github-rdo-centos-9-crc-single-node RETRY_LIMIT in 20m 35s |
|
recheck |
|
recheck last run was |
| @@ -40,7 +40,6 @@ | |||
| enabled: true | |||
| template: | |||
| databaseInstance: openstack | |||
| containerImage: {{ container_registry|default("quay.io") }}/{{ container_namespace|default("podified-antelope-centos9") }}/openstack-glance-api:{{ container_tag | default("current-podified") }} | |||
There was a problem hiding this comment.
ack we have
The two containerImage parameters removed here are the only ones remaining in the test roles. For normal usage, this is defaulted in the operators and we shouldn't need to set it.
For periodic CI, these values are overriden with particular non-latest container URLs via the kustomization mechanism.
So i think these shouldn't be necessary and can be removed too.
Related:
#110 #165