Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded container images from docs and check tests too #110

Closed
jistr opened this issue Aug 16, 2023 · 1 comment
Closed

Remove hard-coded container images from docs and check tests too #110

jistr opened this issue Aug 16, 2023 · 1 comment
Assignees
@cloudguruab
Labels
good first issue Good for newcomers

Comments

@jistr
Copy link
Contributor

jistr commented Aug 16, 2023

We should remove any hard-coded image names from the CRs mentioned in the docs, and if there is anything still in the test suite, that should be removed too.
@jistr jistr added the good first issue Good for newcomers label Aug 16, 2023
@cloudguruab cloudguruab self-assigned this Sep 18, 2023
@jistr
Copy link
Contributor Author

jistr commented Oct 4, 2023

#165

@jistr jistr closed this as completed Oct 4, 2023
jistr added a commit to jistr/data-plane-adoption that referenced this issue Oct 4, 2023
@jistr
Remove remaining container images from test roles
3d755be 
The two containerImage parameters removed here are the only ones
remaining in the test roles. For normal usage, this is defaulted in
the operators and we shouldn't need to set it.

For periodic CI, these values are overriden with particular non-latest
container URLs via the kustomization mechanism.

So i think these shouldn't be necessary and can be removed too.

Related:

openstack-k8s-operators#110
openstack-k8s-operators#165
@jistr jistr mentioned this issue Oct 4, 2023
Merged
jistr added a commit to jistr/data-plane-adoption that referenced this issue Oct 5, 2023
@jistr
Remove remaining container images from test roles
b018949 
The two containerImage parameters removed here are the only ones
remaining in the test roles. For normal usage, this is defaulted in
the operators and we shouldn't need to set it.

For periodic CI, these values are overriden with particular non-latest
container URLs via the kustomization mechanism.

So i think these shouldn't be necessary and can be removed too.

Related:

openstack-k8s-operators#110
openstack-k8s-operators#165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cloudguruab cloudguruab

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jistr @cloudguruab