Show real outgoing bytes #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track producers' "outgoing-byte-total" and consumers' "incoming-byte-total".
chia7712
reviewed
Feb 17, 2022
|
@chinghongfang 剛剛合併了 #214 就噴出一堆衝突了@@ 麻煩再修正一下 |
Add unit test for transactional producer on real bytes output. Fix unit test and make more assertions.
chia7712
reviewed
Apr 5, 2022
chinghongfang
commented
Jun 28, 2022
app/src/main/java/org/astraea/app/performance/MutableMetric.java
Outdated
Show resolved
Hide resolved
|
@chinghongfang 這個進度如何？ |
|
因為 #460 引進了local mbean ，接下來將使用local mbean 來改寫。 |
chia7712
reviewed
Aug 15, 2022
chia7712
previously approved these changes
Aug 17, 2022
app/src/main/java/org/astraea/app/performance/TrackerThread.java
Outdated
Show resolved
Hide resolved
|
@chinghongfang 狀況如何？可否完成最後一個小修改後合併？ |
|
我不了解要用什麼 |
我的意思是前一個 |
chia7712
reviewed
Aug 22, 2022
app/src/main/java/org/astraea/app/performance/TrackerThread.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/app/performance/TrackerThread.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Aug 23, 2022
app/src/main/java/org/astraea/app/performance/TrackerThread.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/app/performance/TrackerThread.java
Outdated
Show resolved
Hide resolved
|
@chinghongfang 不好意思，麻煩修復一下衝突 |
chia7712
reviewed
Aug 23, 2022
app/src/main/java/org/astraea/app/performance/TrackerThread.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/app/performance/TrackerThread.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Aug 23, 2022
app/src/main/java/org/astraea/app/performance/TrackerThread.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#226
我們的performance tool目前只會顯示"serialized value"大小，無法看到真正傳輸出去的資料量大小，由於我們的工具會支援"壓縮"，所以我們更需要真正的傳輸量。
這隻pr在
Producer介面新增一個新的方法，用來獲取producer/consumer的KafkaMetrics，讓我們可以取得producer/consumer內部紀錄的數據。並且將暴露出來的
KafkaMetrics放在astraea.performance.Metrics中保管(計算&轉型)。讓tracker輸出實際傳輸量，提供使用者更多資訊。